Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

development: Add Anchors V2 to PodOperation proxy #1936

Merged
merged 1 commit into from
Jul 31, 2024
Merged

development: Add Anchors V2 to PodOperation proxy #1936

merged 1 commit into from
Jul 31, 2024

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Jul 31, 2024

Description

Adds access to the Anchors V2 calls to the PodOperation proxy type.

@cdamian
Copy link
Contributor Author

cdamian commented Jul 31, 2024

cc @hieronx @onnovisser

@cdamian cdamian requested review from lemunozm and wischli July 31, 2024 14:01
wischli
wischli approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After hours of going back and forth with my review, I think this LGTM 😅

@cdamian cdamian enabled auto-merge (squash) July 31, 2024 14:26
@cdamian cdamian merged commit c4e1400 into main Jul 31, 2024
9 of 10 checks passed
@cdamian cdamian deleted the add-anchors-v2-to-pod-operation-proxy branch July 31, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@lemunozm lemunozm Awaiting requested review from lemunozm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdamian @wischli