Sync StorageVersion of external dependencies

[wischli]

Description

During the execution of try-runtime as part of the release process of #1607, I stumbled upon a few lines of mismatching storage versions for external dependencies for Centrifuge Chain. We need to investigate all of these for the next release 1025 and update to the latest versions.

2023-12-05 08:50:53.521  INFO main runtime::frame-support: ⚠️ ParachainSystem declares internal migrations (which *might* execute). On-chain `StorageVersion(2)` vs current storage version `StorageVersion(2)`
2023-12-05 08:50:53.521 ERROR main runtime::frame-support: **Balances**: On chain storage version StorageVersion(0) doesn't match current storage version **StorageVersion(1**).
2023-12-05 08:50:53.521  INFO main runtime::frame-support: ⚠️ XcmpQueue declares internal migrations (which *might* execute). On-chain `StorageVersion(3)` vs current storage version `StorageVersion(2)`
2023-12-05 08:50:53.521 ERROR main runtime::frame-support: XcmpQueue: On chain storage version StorageVersion(3) doesn't match current storage version StorageVersion(2).
2023-12-05 08:50:53.521  INFO main runtime::frame-support: ⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`
2023-12-05 08:50:53.521  INFO main runtime::frame-support: ⚠️ DmpQueue declares internal migrations (which *might* execute). On-chain `StorageVersion(2)` vs current storage version `StorageVersion(1)`
2023-12-05 08:50:53.521 ERROR main runtime::frame-support: DmpQueue: On chain storage version StorageVersion(2) doesn't match current storage version StorageVersion(1).
2023-12-05 08:50:53.522 ERROR main runtime::frame-support: **OrmlAssetRegistry**: On chain storage version StorageVersion(0) doesn't match current storage version **StorageVersion(2)**.
2023-12-05 08:50:53.522 ERROR main runtime::frame-support: **PriceOracleMembership**: On chain storage version **StorageVersion(0)** doesn't match current storage version **StorageVersion(4)**.
2023-12-05 08:50:53.522  INFO main runtime::frame-support: ⚠️ **Ethereum** declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `NoStorageVersionSet`

TODO

For the following 5 pallets, only two require action:

• XCM related pallets
• Balances
• Ethereum
• OrmlRegistry
• PriceOracleMembership

✅ XCM related pallets

No action required, error message will be gone by upgrading to Polkadot v1.0.0+.

These were upgraded as part of the 1020 upgrade: https://github.com/centrifuge/centrifuge-chain/pull/1522/files#diff-a23bc93c9cdd2a38e36a62edebd1ada7b653b375374674590717116f2e368b32

Apparently, we upgraded to a newer version than marked in the pallet version which we are currently using as dependency.

Example: dmp-queue

• We use v0.9.43 : https://github.com/paritytech/cumulus/blob/b8999fce0f61fb757f9e57e326cda48e70137019/pallets/dmp-queue/src/migration.rs#L27
• Polkadot v1.0.0: https://github.com/paritytech/polkadot-sdk/blob/3ae86ae075ac5eb9b80f89f09bd7f4a63f97c582/cumulus/pallets/dmp-queue/src/migration.rs#L27

🚧 Balances v0 -> v1

Action required: Apply migration

https://github.com/paritytech/substrate/pull/12840/files

🚧 ORML Registry v0 -> v2

Action required: Bump storage versions

AFAICT, we have already executed the v2 migration as part of our 1020 Centrifuge Chain upgrade: https://github.com/centrifuge/centrifuge-chain/pull/1522/files#diff-a23bc93c9cdd2a38e36a62edebd1ada7b653b375374674590717116f2e368b32

✅ pallet_ethereum v0 vs NoStorageVersionSet

No action required, because the pallet has not been versioned.

/// If the storage_version attribute isn't given
/// this is set to [NoStorageVersionSet] to inform the user that the attribute is missing.
/// This should prevent that the user forgets to set a storage version when required. However,
/// this will only work when the user actually tries to call [Self::current_storage_version]
/// to compare it against the [Self::on_chain_storage_version]. If the attribute is given,
/// this will be set to [StorageVersion].

✅ PriceOracleMembership

No action required because dependency will be dropped soon.

How will this affect the code base

Increased security

What are foreseen obstacles or hurdles to overcome?

• Migrations needed, at least for bumping the StorageVersion
• Some of these might have been executed already without us having bumped the storage version

[lemunozm]

Important note. OrderBook needs to close its current order before applying 1025. Is this something that we can do already?

[lemunozm]

Is this already complete right? @wischli

[wischli]

Is this already complete right? @wischli

Yes, fixed by #1747