-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Pool New Designs #2529
Comments
@kattylucy added some more details Section 1: Pool Structure
Section 2: Pool details
Section 3: Pool setup
Top Progress section
After clicking Create pool
|
@kattylucy as discussed here's an overview of most of the data and where it should be sent, hope I didn't miss too much! Create pool dataGet new pool ID by calling: Create proxies must be called before anything else, the result will be 2 pure proxies (AO proxy = asset originator proxy, admin proxy). The AO proxy will be used to give the admin proxy permissions. The admin proxy will be passed into Step 1
{
tokenName: string
symbolName: string
interestRate: number | ''
minRiskBuffer: number | ''
minInvestment: number | ''
targetAPY?: string | '' // possibly change this to { apy: {[type]: value} } ?
}
{
trancheType: 'Residual' | { NonResidual: {.interestRatePerSecond: string, minRiskBuffer: string } }
metadata: {
tokenName: string,
tokenSymbol: string,
},
}[] where junior tranche trancheType = residual Step 2All values belong in pool metadata. Keep in mind that all files (pdf, svg, jpeg) need to be pinned to IPFS first, their hash will then be the value in the pool metadata Step 3Multisigif single, hide threshold section since it's not applicable without a multisig:
if multisig:
adminMultisig?: {
signers: string[];
threshold: number;
}
substrate.addMultisig(
signers: string[];
threshold: number;
) Asset originators
@onnovisser can you please clarify what's can and can't be done before pool creation regarding AOs? FeesFirst fee is fixed. Rest of fees can be entered freely. If primary asset class is "Public Credit", the Fee in % of NAV is 0.4%
poolFees: { id: number; name: string; feePosition: 'Top of waterfall'; category?: string; feeType: FeeTypes }[]
[
'Top',
{
destination: fee.destination,
editor: fee?.account ? { account: fee.account } : 'Root',
feeType: { [fee.feeType]: { limit: { [fee.limit]: fee?.amount } } },
},
][] Onboardingif centrifuge onboarding is selected: show one upload button per tranche and show tax requirements checkbox
onboarding?: {
tranches: { [trancheId: string]: { agreement: FileType | undefined; openForOnboarding: boolean } }
taxInfoRequired?: boolean
}
check OnboardingSettings.tsx for implementation. if external is selected: show a text input where a link can be entered for external onboarding onboarding?: {
externalOnboardingUrl?: string
} if other: show nothing on the right hand side and don't submit any pool metadata for onboarding, means onboarding is currently manual or closed the key |
To have AO delegates (The hot wallets that can originate assets and borrow) be set during pool creation, you'd need to add the delegates to the AO proxy in the batch that sets the admin proxy as a delegate of the AO proxy:
In the follow-up transaction after pool creation, the permissions of the AO would need to be set ( |
@kattylucy spoke with @mustermeiszer re Pool managers We will keep the UI as it is today. You can either pick Single wallet address, where we can auto populate the wallet address of the user creating the pool. But with the ability to edit the address. No CTA to add another. To add multiple pools, they have to select Multi-sig. But they can still select 1 out of X many wallet addresses in their config threshold. |
These warnings for min characters only shows up when trying to move to the next page. Can we add these in the titles. For example If a Service provider type has been selected, they need to add the name. So we need a warning underneath the text box if it has been left blank like But the user should also be able to leave the Type for Service provider blank. Right now if they select one field, they can't go back to blank option. Same with the Ratings. If they add a ratings agency, they have to add the rating value and upload either URL or PDF. We also need to add the option to delete if a 2nd rating is added. For multi-sig, we should show 2 wallet address text bars, with Add another CTA (similar to Figma). The config settings for multi-sig seems off. It should count the number of wallet addresses (seems to be counting 3, when there are only 2 text boxes) and let the user pick how many they want for threshold. Not have "1" in the title when 2 has been selected from the dropdown. Pool delegates title and description is missing above this. Add another CTA also seems off, should be more to the right aligned with the text bar (as in Figma). Can we do |
so Service provider type is not mandatory? @sonam-jo "But the user should also be able to leave the Type for Service provider blank. Right now if they select one field, they can't go back to blank option" |
That's right. They don't have to pick a service provider at all and leave it all blank. Or if they pick one provider, then adding the name is mandatory. Once I selected fund admin, I wasn't able to go back to blank. |
Even though I've filled everything out, I can't create the pool. We're not allowing the Ethereum address as well for pool managers and asset originators. Need to make sure we inherit that from the previous functionality @kattylucy |
I just fixed the bug with non-being able to create a pool. Under the hood we are converting address to substrate @0x4Graham
|
But do you see the error message saying invalid address? @kattylucy |
Additional one to add: Pool delegate: cc @kattylucy |
Part of the redesign project. Here are the designs for Creating a new pool: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=3492-508&node-type=canvas&t=SzkFDzqaCS5Gz1Fa-0
Main Changes
Instead of a single long page, we will break down the pool creation into 4 sections:
When in progress, it should be filled with the yellow (FFC012)
When all information has been completed and have moved to the next item, it should change to green
In Pool Structure:
It will not be possible to choose which chain to deploy to. Therefore exclude from MVP
In Pool details, under Service Providers. The user can select the type of Service provider. If one does not exist, you can give the option to create a new one.
NB: If this is too much work, please exclude this. We can add later in a feature.
Part of Pool Setup,
We will be adding the "Investor Onboarding Section", which is currently not in the pool creation flow.
Here will give the options that are presented if the user were to edit the Pool configuration. It will now be in the initial pool creation flow.
The text was updated successfully, but these errors were encountered: