Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opencensus not working with Flask 2 #1022

Closed
bogdancondurache opened this issue Apr 20, 2021 · 3 comments · Fixed by #1119 · May be fixed by #1072
Closed

Opencensus not working with Flask 2 #1022

bogdancondurache opened this issue Apr 20, 2021 · 3 comments · Fixed by #1119 · May be fixed by #1072
Labels
bug

Comments

@bogdancondurache
Copy link

bogdancondurache commented Apr 20, 2021 •
edited
Loading

Describe your environment.
I'm using Python 3.8 and because of some performance changes in Flask 2, I will need to use it, even if it's an RC version. Namely Flask==2.0.0rc1. Now, the problem is that opencensus-ext-flask has a dependency on Flask with version < 2. This is not a bug per se, nor a feature, but it would be nice to have opencensus-ext-flask see Flask 2 as a valid dependency, without us having to clone it and change that dependency

Steps to reproduce.
Install Flask==2.0.0rc1 and opencensus-ext-flask==0.7.4

What is the expected behavior?
Having them installed and working.

What is the actual behavior?

The conflict is caused by:
     opencensus-ext-flask 0.7.4 depends on flask<2.0.0 and >=0.12.3
@alexkyllo
Copy link

I also have a Flask application that is stuck on Flask <2.0.0 due to this dependency. Would the maintainer(s) of this package review a PR to add Flask 2 support if I opened one?

@mortendaehli
Copy link

I have added a PR for this one, but it may take some time before anyone is looking at it. Any idea how we can speed this up?

@bogdancondurache
Copy link
Author

maybe @lzchen or @aabmass could help with this one

@mortendaehli mortendaehli mentioned this issue Sep 18, 2021
Open
@lzchen lzchen mentioned this issue Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@alexkyllo @mortendaehli @bogdancondurache