Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Serialization error for Traces between PHP and Go daemon #244

Open
subnova opened this issue Aug 29, 2019 · 0 comments
Open

Serialization error for Traces between PHP and Go daemon #244

subnova opened this issue Aug 29, 2019 · 0 comments

Comments

@subnova
Copy link

subnova commented Aug 29, 2019

The go daemon requires stackTrace to be an array of strings.

https://github.com/census-instrumentation/opencensus-php/blob/master/daemon/processor/local/helper_types.go#L37

However, the Span class in the PHP library sets the stackTrace to an array of objects.

https://github.com/census-instrumentation/opencensus-php/blob/master/src/Trace/Span.php#L226

DaemonClient should serialize the objects before sending them to the daemon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant