-
Notifications
You must be signed in to change notification settings - Fork 87
Refactor out EventMachine dependencies. #201
Comments
|
websocket-driver is also quite easy to integrate into a celluloid-io loop: https://gist.github.com/Asmod4n/241c84ef31df921b31e9/c15bd4e3be2efd261f325d18eec126f1e9649b62 |
Thanks @jcoglan, that makes sense and explains what I've been seeing. Maybe we ought to extract all websocket code from Reel, and create We can support hijacking in the |
@digitalextremist Yep, EM is only used to run the example in the |
Even though
Celluloid
andEventMachine
are mutually exclusive, whenReel
is installed,EventMachine
comes along, because whether used or not,websocket-driver
and otherfaye-*
gems bring in anEventMachine
dependency. This has affectedactioncable
also, throughfaye-*
dependencies, and it is being addressed in this thread: rails/actioncable#16In our next release bringing in
HTTP/2
( #198 ) we need to also refactor out dependencies which bring inEventMachine
, whether it be used or not, and provide completeCelluloid::IO
support for websockets, by refactoring thefaye-*
gems in parallel with this next release.This will be achieved one of two ways:
EventMachine
in a version of his gems.faye-*
gems asCelluloid::WebSocket
which would also solve our need to bringcelluloid-websocket-client
back up to speed with thefaye-*
gems./cc: @tarcieri, @dhh, @jcoglan, @kenichi, @jasonayre
The text was updated successfully, but these errors were encountered: