Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

#wait_readable and #wait_writable have different signature than the ruby methods #169

Open
HoneyryderChuck opened this issue Jan 18, 2016 · 3 comments

Comments

@HoneyryderChuck
Copy link

Was inspecting http://ruby-doc.org/stdlib-2.0.0/libdoc/io/wait/rdoc/IO.html#method-i-wait_readable for removal of IO.select calls on some internal stuff. Both wait_* methods accept a timeout parameter. Also, #wait_readable is aliased to #wait . Don't know about the other ones.

@tarcieri
Copy link
Member

Yeah, these are the new io/wait API introduced in Ruby 2.0, which Celluloid::IO predates.

I think we should try to support the upstream API.

@HoneyryderChuck
Copy link
Author

@tarcieri , either one wraps the #wait call in a Celluloid.timeout, or nio4r should provide support for timed-out IO monitors. Is option B possible?

@HoneyryderChuck
Copy link
Author

Shall we continue the discussion here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants