Bugfix - a task will run multiple times when chaining chains with groups #9021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9021 +/- ##
==========================================
- Coverage 77.80% 77.78% -0.02%
==========================================
Files 150 150
Lines 18682 18682
Branches 3194 3194
==========================================
- Hits 14535 14532 -3
- Misses 3854 3856 +2
- Partials 293 294 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
reviewed
May 13, 2024
pencil
added a commit
to Outset-AI/celery
that referenced
this pull request
May 13, 2024
Co-authored-by: Nils Caspar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9020
On
_chain.__or__there is already a logic that knows to take a group/chord, and check if it needs an upgrade to chord. The problem is that if we chain 2 chains, it skips this logic and just constructs a chain from all the tasks, without any checks for an upgrade. Therefore, in a case where the first chain ends with a group, it will not create a chord.