Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Gradle configuration doesn't update values in Talaiot report #390

Open
wzieba opened this issue Feb 26, 2024 · 2 comments
Open

Comments

@wzieba
Copy link
Contributor

wzieba commented Feb 26, 2024

馃憢 hi there, I think I located an issue in the plugin related to configuration cache.

Actual behavior

When setting a new value of Gradle configuration, like org.gradle.workers.max or org.gradle.configureondemand and running a build that has a configuration cache, Talaiot report shows old values.

Expected behavior

Report from Talaiot always shows correct values of Gradle configuration options.


Here is the reproduction https://github.com/cdsap/Talaiot/compare/master...wzieba:Talaiot:configuration_cache_issue?expand=1

It seems that when a project uses a configuration cache, the values taken from Gradle#startParameters (or maybe other places as well) are not updated.

@wzieba
Copy link
Contributor Author

wzieba commented Feb 28, 2024

Unfortunately, it might not be possible to fix: https://discuss.gradle.org/t/is-there-a-way-to-get-up-to-date-gradle-start-parameters-with-configuration-cache/47806

Maybe there could be a warning logged somewhere or in the README?

@cdsap
Copy link
Owner

cdsap commented Mar 2, 2024

good idea, will update the readme.
Thanks for checking this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants