EnvFrom multiple refs should be separate

[burner1024]

Description of the bug:

const deploymentEnv = new kplus.EnvFrom(depConfigMap, undefined, depSecret);

Use it in deployment.containers.envFrom. Resulting yaml is

- envFrom:
    - configMapRef:
      name: cmName
      secretRef:
      name: secretName

That won't work:
Deployment.apps "dep" is invalid: spec.template.spec.containers[0].envFrom: Invalid value: "": may not have more than one field specified at a time

Expected output:

- envFrom:
    - configMapRef:
      name: cmName
    - secretRef:
      name: secretName

Reproduction Steps:

See above

Error Log:

Environment:

• Framework Version: cdk8s-plus-30
• OS:

Other:

---

This is 🐛 Bug Report

[iliapolo]

Yeah I agree its a bug and we should throw an error instead of generating the invalid manifest. But actually the EnvFrom class is not meant to be used directly. If you want to create multiple envFrom elements, do this:

const env = [
  kplus.Env.fromConfigMap(depConfigMap),
  kplus.Env.fromSecret(depSecret),
]