Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add multiple annotations at once #2291

Open
2 tasks
oleghind opened this issue Dec 11, 2024 · 0 comments
Open
2 tasks

Ability to add multiple annotations at once #2291

oleghind opened this issue Dec 11, 2024 · 0 comments
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@oleghind
Copy link

oleghind commented Dec 11, 2024

Description of the feature or enhancement:

Instead of adding annotations one by one allow adding an object with all the annotations by introducing a new method "addAnnotations" to ingress.

Use Case:

Improvement for code quality.

Proposed Solution:

The resulting code can look like this, which is a lot nicer than 5 calls of addAnnotation:

    const ingressAnnotations = {
      'kubernetes.io/ingress.class': 'alb',
      'alb.ingress.kubernetes.io/target-type': 'ip',
      'alb.ingress.kubernetes.io/scheme': 'internet-facing',
      'alb.ingress.kubernetes.io/healthcheck-path': '/ping',
      'alb.ingress.kubernetes.io/listen-ports': '[{"HTTP": 80}, {"HTTPS": 443}]'
      };
    ingress.metadata.addAnnotations(ingressAnnotations);
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@oleghind oleghind added feature-request New/Enhanced functionality wanted needs-triage Priority and effort undetermined yet labels Dec 11, 2024
@iliapolo iliapolo added effort/small 1 day tops priority/p2 Dependent on community feedback. PR's are welcome :) @component/cdk8s-plus Issue related to cdk8s-plus and removed needs-triage Priority and effort undetermined yet labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

No branches or pull requests

2 participants