workload Select() function updates the selector, but not the toPodSelectorConfig function

[sthomson-wyn]

Description of the bug:

When updating the matchlabels for a workload (say, a deployment), updating the pod selector does not update the output of the toPodSelectorConfig function

Reproduction Steps:

Create a deployment, and update the selector labels:

deployment := cdk8splus31.NewDeployment(chart, &deploymentName, &cdk8splus31.DeploymentProps{
		Select:                       boolPtr(false),
...
})
deployment.Select(cdk8splus31.LabelSelector_Of(&cdk8splus31.LabelSelectorOptions{
		Labels: &selectorLabels,
	}))

Results in the correct matchLabels in my deployment

apiVersion: apps/v1
kind: Deployment
metadata:
  name: my-deployment
spec:
  selector:
    matchLabels:
      my-selectors: hello-world

However, when trying to use said deployment for a Service (or any other thing that uses an IPodSelector)

svc := cdk8splus31.NewService(chart, strPtr(*config.ServiceName+"-svc"), &cdk8splus31.ServiceProps{
  Selector: deployment,
})

Results in

apiVersion: v1
kind: Service
metadata:
  name: my-svc
spec:
  ports:
    - name: http
      port: 80
      protocol: TCP
  selector:
    cdk8s.io/metadata.addr: my-deployment-c8aaf3f2
  type: ClusterIP

Environment:

• Framework Version: 2.198.254
• OS: Ubuntu

Other:

---

This is 🐛 Bug Report

[iliapolo]

@sthomson-wyn Just to make I understand, did you expect to see:

apiVersion: v1
kind: Service
metadata:
  name: my-svc
spec:
  ports:
    - name: http
      port: 80
      protocol: TCP
  selector:
    my-selectors: hello-world
  type: ClusterIP

?

[sthomson-wyn]

@iliapolo yep, that's what I would expect

[iliapolo]

I see. Does this have undesired affects though? does the cdk8s.io/metadata.addr: my-deployment-c8aaf3f2 selector exist on the pod template metadata? If it does, it still uniquely selects the deployment you tell it to.

I'll mark this as a feature request as this is behaving as intended, the question now is there a gap in functionality here or not. Agree its confusing though because the cdk8s.io/metadata.addr gets special treatment where maybe it shouldn't.