Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running in Bazel #804

Closed
jacobshirley opened this issue Jan 18, 2023 · 2 comments · Fixed by #907
Closed

Running in Bazel #804

jacobshirley opened this issue Jan 18, 2023 · 2 comments · Fixed by #907

Comments

@jacobshirley
Copy link

Describe the bug
Bazel complains that express is not installed. This is because express should be in "dependencies" rather than "devDependencies" in the package.json.

To fix this, "express" needs to be in "dependencies"
@cdimascio
Copy link
Owner

Thanks. This should be peerDependencies

@jacobshirley
Copy link
Author

Yep, that would make more sense

marvinruder added a commit to marvinruder/express-openapi-validator that referenced this issue Mar 5, 2024
@marvinruder
Add express as peer dependency
8174935 
* Fixes cdimascio#804

Signed-off-by: Marvin A. Ruder <[email protected]>
@marvinruder marvinruder mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add express as peer dependency marvinruder/express-openapi-validator
2 participants
@jacobshirley @cdimascio