-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native fetch] fallback to native fetch doesn't support proxy agent #22353
Comments
in browsers, proxies are not supported, even with node-fetch (https://www.google.com/search?q=node-fetch+proxy+support+in+browser). That's a security feature in browsers not to allow proxy within fetch. edit: ah, I think I misunderstood. so, you use the bundle in backend, right? hm, seems a valid point, if fallback is used. we will look into this and post an update. |
can you please mention exactly which bunder do you use or even it would be nice if you share a simplified project (with tsconfig/package.json) so we would use the same bundling process to reproduce the problem. |
With I'm using webpack latest version. Simplified project: fetch-test.zip |
Operating System
All
Programming Languages
JavaScript
CCXT Version
Latest
Description
Currently if
ccxt
doesn't findnode-fetch
it use nativefetch
as a fallback here: https://github.com/ccxt/ccxt/blob/master/ts/src/base/Exchange.ts#L1166unfortunately native
fetch
doesn't support proxy agent because it follow the original implementation from web browsers 😟my question is, why not bundle
node-fetch
insideccxt
and avoid using an incomplete fallback? Or at least I think it should be added in the documentation?The text was updated successfully, but these errors were encountered: