From e68e19d3f59f0e4860fb50817636f57526570049 Mon Sep 17 00:00:00 2001 From: "T. Todua" <7117978+ttodua@users.noreply.github.com> Date: Thu, 9 May 2024 14:23:10 +0400 Subject: [PATCH] feat(base) - safeIntegerOmitZero (#22244) * feat(base) - safeIntegerOmitZero * fix(latoken) - zero ts in tickers * minor bitget * parseint * Update Exchange.ts * fix linting --------- Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com> --- ts/src/base/Exchange.ts | 8 ++++++++ ts/src/bitget.ts | 6 +----- ts/src/latoken.ts | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/ts/src/base/Exchange.ts b/ts/src/base/Exchange.ts index 7936eb80e7ef..662b459e7f00 100644 --- a/ts/src/base/Exchange.ts +++ b/ts/src/base/Exchange.ts @@ -2523,6 +2523,14 @@ export default class Exchange { return res === 0; } + safeIntegerOmitZero (obj: object, key: IndexType, defaultValue: Int = undefined): Int { + const timestamp = this.safeInteger (obj, key, defaultValue); + if (timestamp === undefined || timestamp === 0) { + return undefined; + } + return timestamp; + } + afterConstruct () { this.createNetworksByIdObject (); } diff --git a/ts/src/bitget.ts b/ts/src/bitget.ts index f4a2bc2106dd..65f2741b0378 100644 --- a/ts/src/bitget.ts +++ b/ts/src/bitget.ts @@ -2632,11 +2632,7 @@ export default class bitget extends Exchange { // const marketId = this.safeString (ticker, 'symbol'); const close = this.safeString (ticker, 'lastPr'); - const timestampString = this.omitZero (this.safeString (ticker, 'ts')); // exchange sometimes provided 0 - let timestamp = undefined; - if (timestampString !== undefined) { - timestamp = this.parseToInt (timestampString); - } + const timestamp = this.safeIntegerOmitZero (ticker, 'ts'); // exchange bitget provided 0 const change = this.safeString (ticker, 'change24h'); const open24 = this.safeString (ticker, 'open24'); const open = this.safeString (ticker, 'open'); diff --git a/ts/src/latoken.ts b/ts/src/latoken.ts index 616778ca19dd..4581b7346d04 100644 --- a/ts/src/latoken.ts +++ b/ts/src/latoken.ts @@ -624,7 +624,7 @@ export default class latoken extends Exchange { // const marketId = this.safeString (ticker, 'symbol'); const last = this.safeString (ticker, 'lastPrice'); - const timestamp = this.safeInteger (ticker, 'updateTimestamp'); + const timestamp = this.safeIntegerOmitZero (ticker, 'updateTimestamp'); // sometimes latoken provided '0' ts from /ticker endpoint return this.safeTicker ({ 'symbol': this.safeSymbol (marketId, market), 'timestamp': timestamp,