-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for configuration overrides / replacement #284
Comments
I'm not really familiar with VSCode Peacock, looking at the theme files in your repo, it looks like those are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm looking to add support for peacock and previously created a repo for it to allow for the user to change favorite colors.
Currently this vscode theme only allow for extensions to swap out color contributions from vscode extensions. However peacock does not contribute any colors to the vscode theme and favorites colors are a configuration contribution.
The type generation only allows for
contributes.colors
to be extracted and changed. I'm not sure what the best solution is here to allow forcontributes.configuration.properties.favoriteColors
to be changed/edited when changing the theme.I'm not sure if this means the property is not themable in this case. If this cannot be supported, please reopen the original issue.
The text was updated successfully, but these errors were encountered: