Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest changes break plugin #213

Closed
1 task done
srogozhin opened this issue May 12, 2024 · 10 comments · Fixed by #214
Closed
1 task done

Latest changes break plugin #213

srogozhin opened this issue May 12, 2024 · 10 comments · Fixed by #214
Labels
bug Something isn't working waiting on author

Comments

@srogozhin
Copy link

srogozhin commented May 12, 2024

Is there an existing issue outlining your problem?

  • I have searched the existing issues and they do not solve my problem.

Describe your problem.

When I updated to the latest version (as of 9 hours ago reading this), 4a561f9, Catppuccin no longer loads. When I source the config, i get ~/.local/state/tmux/plugins/tpm/tpm' returned 1.

In my plugins folder, i switched to commit, 2292669 (before the color interpolation changes), and it started working normally.

For now, I have a workaround by keeping on commit, 2292669, so no rush and thank you for all of your hard work 💪 .

Paste your configuration.

set-option -sa terminal-overrides ",xterm*:Tc"

unbind C-b
set -g prefix C-Space
bind C-Space send-prefix

# -n is short for the root table (no-prefix)
bind -n M-H previous-window
bind -n M-L next-window

# vi mode bindings
# -T <key-bind-table> <key> send-keys -X <action>
bind-key -T copy-mode-vi y send-keys -X copy-selection \; send-keys -X cancel
bind-key -T copy-mode-vi v send-keys -X begin-selection
# bind is an alias of bind-key
bind -T copy-mode-vi W send-keys -X next-word \; send-keys -X begin-selection \; send-keys -X previous-word
#
#
# # opens splits with same directory as window
bind '"' split-window -c '#{pane_current_path}'
# bind-key by itself is the same as bind-key -T prefix
bind % split-window -h -c '#{pane_current_path}'
#
# # set global on all sessions
set -g mouse on
# # set global on all windows in session
setw -g mode-keys vi

set -g status-position top

set-environment -g TMUX_PLUGIN_MANAGER_PATH '~/.local/state/tmux/plugins/'

set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'catppuccin/tmux'
run '~/.local/state/tmux/plugins/tpm/tpm'

Attach screenshots.

Before latest update (2292669)
working

After latest update (4a561f9)
not working

What tmux version are you seeing the issue on?

tmux 3.4

Any additional comments?

No response

@srogozhin srogozhin added the bug Something isn't working label May 12, 2024
@vdbe
Copy link
Collaborator

vdbe commented May 12, 2024

Are you on macos?

@vdbe
Copy link
Collaborator

vdbe commented May 12, 2024

Can you test if #214 fixed it (already in main)

@vdbe vdbe linked a pull request May 14, 2024 that will close this issue
@vdbe
Copy link
Collaborator

vdbe commented May 15, 2024

Can anyone on macos confirm that the fix worked?

@thehatchcloud
Copy link

I just tried loading from your fork @vdbe, and it loaded successfully.

@vdbe
Copy link
Collaborator

vdbe commented May 16, 2024

Sorry meant this repository, but the fix made it already in the main of my fork so no worries.

@thehatchcloud Thank you very much

Going to leave this open for a few more days just to be safe.

@thehatchcloud
Copy link

Sure thing. I can try from here too. How do you install a plugin from a different commit or branch? I don't know the syntax to do that.

@vdbe
Copy link
Collaborator

vdbe commented May 16, 2024

set -g @plugin 'catppuccin/tmux'
The fix already made it to the main branch of the plugin. (You also already tested it by using my fork)

@thehatchcloud
Copy link

Hmmm... If I reset my tmux config to us 'catppuccin/tmux' nothing installs now. It seems to skip right over it:

Already installed "tpm"                                                                                                           [0/0]
Already installed "tmux"
Already installed "tmux-sensible"

TMUX environment reloaded.

Done, press ESCAPE to continue.

If I go back to using your repo, it works fine:

Already installed "tpm"                                                                                                           [0/0]
Already installed "tmux-sensible"
Installing "catppuccin-tmux"
  "catppuccin-tmux" download success

TMUX environment reloaded.

Done, press ESCAPE to continue.

Am I doing something wrong, or is there still a problem?

@vdbe
Copy link
Collaborator

vdbe commented May 16, 2024

It's installing, the plugin named tmux is catppuccin. See #129

@thehatchcloud
Copy link

Thank you for the clarification. Now that I understand the naming context, I figured out what was going on.

The ~/.tmux/plugins/tmux folder was there but was empty. Because I didn't realize that was catppuccin, I never touched it. Once I read #129, I deleted the folder and re-ran updates, and everything started working as expected.

Thanks again for the help! 🥇

@vdbe vdbe closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on author
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants