Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Verify that all accent zips are themed as intended #220

Closed
1 task done
sgoudham opened this issue May 22, 2024 · 1 comment · Fixed by #232
Closed
1 task done

Verify that all accent zips are themed as intended #220

sgoudham opened this issue May 22, 2024 · 1 comment · Fixed by #232
Labels
Milestone

Comments

@sgoudham
Copy link
Contributor

sgoudham commented May 22, 2024

Is there an existing issue outlining your problem?

  • I have searched the existing issues and they do not solve my problem.

Describe the issue.

gtk/build.py

Lines 236 to 251 in febd32f

ctp_to_colloid = {
"rosewater": "pink",
"flamingo": "pink",
"pink": "pink",
"mauve": "purple",
"red": "red",
"maroon": "red",
"peach": "orange",
"yellow": "yellow",
"green": "green",
"teal": "teal",
"sky": "teal",
"sapphire": "default",
"blue": "default",
"lavender": "default",
}

  ctp_to_colloid = { 
-     "rosewater": "pink", 
-     "flamingo": "pink", 
      "pink": "pink", 
      "mauve": "purple", 
      "red": "red", 
-     "maroon": "red", 
      "peach": "orange", 
      "yellow": "yellow", 
      "green": "green", 
      "teal": "teal", 
-     "sky": "teal", 
-     "sapphire": "default", 
-     "blue": "default", 
+     "blue": "blue", 
-     "lavender": "default", 
 } 

Context: I don't think we should continue to publish binaries under our accent names that don't accurately reflect the Catppuccin accent.

@nullishamy has pointed out, this command maps the Catppuccin accent to Colloid's colours, essentially meaning that we're building duplicate zips? Happy to be proven wrong on this.

install_cmd: str = f"./install.sh -c {theme_style} -s {size} -n {name} -d {dest} -t {def_color_map[accent]}"

@sgoudham sgoudham added the meta label May 22, 2024
@isabelroses
Copy link
Member

They still build to the correct accent. i.e. sapphire still builds to sapphire, not to upstream "default". Seems fine to leave it as is.

@sgoudham sgoudham changed the title Remove It 👍 Verify that all accent zips are themed as intended May 22, 2024
@nullishamy nullishamy added this to the v1.0.0 milestone May 24, 2024
@nullishamy nullishamy linked a pull request May 24, 2024 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants