Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Broken rounded corners of firefox and thunderbird #129

Open
1 of 5 tasks
wiraki opened this issue Oct 25, 2023 · 7 comments
Open
1 of 5 tasks

Broken rounded corners of firefox and thunderbird #129

wiraki opened this issue Oct 25, 2023 · 7 comments
Labels
bug Something isn't working repro:mixed This issue can be partly reproduced source:upstream Bug exists in upstream

Comments

@wiraki
Copy link

wiraki commented Oct 25, 2023

Describe the bug
Corners of these two applications are not correctly rounded. See screenshots.

Mention your distribution and your theme version
Pop!_OS 22.04 LTS x86_64
Theme: Catppuccin-Macchiato-Standard-Teal-Dark

Select how you installed the theme

  • GitHub Releases
  • AUR package
  • Nixpkg
  • Using the python install script
  • Flatpak

Symlinked the gtk-4.0 folder?
Have you symlinked the gtk-4.0 folder as mentioned in the README? This is not applicable for users who have installed the theme with the Nixpkg.
Yes.

Expected behavior
Corners should be round like other GTK applications. Instead, these two mozilla applications have a sharp corner super-imposed on the round corners.

Screenshots
Top corner:
image

Bottom corner:
image

Additional context
I am aware of issue #2. However, I don't want to change the radius or anything like that, I would just like the theme to apply as it should.
I have also tried suggestions from https://bugzilla.mozilla.org/show_bug.cgi?id=1408360, but they did not work.

Other GTK themes, such as Nordic do not have this issue.

Thanks for looking into it!

@ghostx31 ghostx31 pinned this issue Oct 25, 2023
@ghostx31 ghostx31 unpinned this issue Oct 25, 2023
@ghostx31
Copy link
Member

Oops. Misclicked. Checked this out, definitely an issue. I'll need to check if Colloid upstream has this issue open or not.

@nydexx
Copy link

nydexx commented Apr 29, 2024

same issue

@nullishamy
Copy link
Contributor

Closing as presumed resolved in upstream. Open a new report if it is still broken.

@wiraki
Copy link
Author

wiraki commented May 20, 2024

Just installed latest release 1.0.0-rc2. The issue is not fixed.

I would rather you re-open this issue instead of me opening a new report, as I don't have anything different to report.

Did you determine whether it was a colloid issue?

Edit: Should I try 0.7.5 instead?

@nullishamy
Copy link
Contributor

1.0.0-rc2 would be as up to date as 0.7.5, possible better. We can reopen this and report upstream (or link to an upstream issue if it exists) 👍

No work appears to be done to check if this is an upstream issue. This can checked by installing the colloid theme itself and seeing if the issue persists. If not, there must be an issue downstream that we can work on fixing!

@nullishamy nullishamy reopened this May 20, 2024
@nullishamy nullishamy added the bug Something isn't working label May 20, 2024
@nullishamy
Copy link
Contributor

nullishamy commented May 21, 2024

image
Cannot repro top corner issues

image
Can repro bottom corner issues.

Can't really find a cause, it seems like FF broadly isnt respecting the WM, should be reported upstream. Tested on v1.0.0-rc3

@nullishamy nullishamy added source:upstream Bug exists in upstream repro:mixed This issue can be partly reproduced labels May 21, 2024
@wiraki
Copy link
Author

wiraki commented May 22, 2024

How strange that we don't have the same behavior for the top one though, do you have any idea what I could try?

Edit:

This can checked by installing the colloid theme itself and seeing if the issue persists. If not, there must be an issue downstream that we can work on fixing!

I will try this at some point when I have time, this week is crazy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working repro:mixed This issue can be partly reproduced source:upstream Bug exists in upstream
Projects
None yet
Development

No branches or pull requests

4 participants