Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_params for put step #10

Open
Hertog-PJ opened this issue Oct 1, 2019 · 2 comments
Open

Add get_params for put step #10

Hertog-PJ opened this issue Oct 1, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@Hertog-PJ
Copy link

Hi

Would it be possible to add a get_params to the out parameters in which you can disable the download step after uploading a chart to the museum.

Currently when uploading a chart to the museum, the put step will try to validate this by immediately downloading the new chart from the chart museum.

It would be nice to have more control over this by being able to disable this verification step.

This parameter is for example also used for the docker image concourse resource (https://github.com/concourse/docker-image-resource) where they have the get_params to skip the validation step.

@headcr4sh
Copy link
Member

Seems like a legit extension. If it can be done, I'll gladly review (and merge) any PR that might add such a feature.

@headcr4sh headcr4sh added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 2, 2019
@headcr4sh headcr4sh added this to the 0.3.0 milestone Oct 2, 2019
@headcr4sh headcr4sh modified the milestones: 0.9.0, 1.1.0 Mar 9, 2020
@fenech
Copy link

fenech commented Jul 27, 2022

Greetings from the future! I have a related issue to this one, and I was thinking about making some modifications to the "put" step, but I just wanted to clarify something.

Currently the resource immediately re-downloads the chart that it pushed, during the "put" step . In our registry, this part is causing us intermittent problems, since it seems that sometimes, the chart is not ready in time to download straight away:

{"errors":[{"code":"NOT_FOUND","message":"fail to get chart version: no chart version found for ourchart-X.Y.Z"}]}

Then (following the Concourse convention) it also does an implicit "get" step. So normally we end up downloading the chart twice.

I just wanted to clarify whether this switch to skip the download during the implicit "get" should also affect the behaviour of the "put"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants