Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed types in ferc2 partition value causes complexity downstream #211

Open
zaneselvans opened this issue Dec 3, 2023 · 0 comments
Open
Labels
ferc2 FERC Form 2

Comments

@zaneselvans
Copy link
Member

The early ferc2 data was split into two parts per year (split alphabetically based on the name of the respondent) while in later years the data is not split. There are some years in which both split and unsplit data were published.

We use a partition named part to identify these portions of the data, with values of: 1, 2, or None.

The use of mixed types in the partition values creates some probably unnecessary complexity downstream, where the different values need to be handled separately. (e.g. you can't sort the partition values, because None can't be compared with an integer)

If possible we should probably try and keep the partition values homogeneous in type to avoid this complexity. In this case, maybe we could use part=0 to indicate that the data is unsplit?

@zaneselvans zaneselvans added the ferc2 FERC Form 2 label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ferc2 FERC Form 2
Projects
None yet
Development

No branches or pull requests

1 participant