Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect appearance of ability to spend cashu token twice #295

Open
deerwhisper2310 opened this issue Jan 18, 2024 · 1 comment
Open

Incorrect appearance of ability to spend cashu token twice #295

deerwhisper2310 opened this issue Jan 18, 2024 · 1 comment
Assignees
Labels
UX User experience related

Comments

@deerwhisper2310
Copy link

deerwhisper2310 commented Jan 18, 2024

Describe the bug
Attempting to claim an ecash token twice increases the user's displayed (not actual) balance twice, and the 2nd tx doesnt show up in transaction history. This was done sending from Minibits to Enuts

To Reproduce
Steps to reproduce the behavior:

  1. Add mint.minibits.cash to Enuts
  2. Open Minibits (using the default mint.minibits.cash)
  3. Click 'Send', then 'Share ecash'
  4. Enter an amount (I included a memo both times I did this)
  5. Ensure you are paying from mint.minibits.cash, and click 'Send now'
  6. Click 'Copy'
  7. Open Enuts
  8. Click 'Receive', then 'Redeem Ecash'
  9. When asked to 'Trust this mint?', click 'Trust mint', then go back to the dashboard
  10. See that there has been a successful tx and that the total sats balance has increased
  11. Repeat step 8
  12. When asked to 'Trust this mint?' again, click 'Auto-swap to default mint'
  13. Enuts should tell you it's awaiting an invoice, then that an error occurred when requesting invoice from mint
  14. Go back to dashboard and see that the total sats balance at the top of the screen has increased again by the same amount, but there is no history of the 2nd tx

Expected behavior
I believe the 2nd attempt to redeem the ecash should be rejected as it has already been spent. The user's balance shouldn't increase as a result.

Smartphone:

  • Device: Pixel 6
  • OS: GrapheneOS
@deerwhisper2310 deerwhisper2310 changed the title Redeemed Ecash token twice Redeemed Ecash token twice? Jan 18, 2024
@deerwhisper2310
Copy link
Author

After attempting to cash out, I was given an error message and told to Check Proofs. I had attempted to check the proofs already several times but the balance dropped back to where it should've been once it was complete this time.

It now appears to me that this is purely a visual bug that looks like an ecash token being spent twice.

The expected result is still that the 2nd attempt to spend should be rejected and the balance seen in the app should not increase.

@deerwhisper2310 deerwhisper2310 changed the title Redeemed Ecash token twice? Incorrect appearance of ability to spend cashu token twice Jan 19, 2024
@KKA11010 KKA11010 self-assigned this Jan 19, 2024
@KKA11010 KKA11010 added the UX User experience related label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience related
Projects
None yet
Development

No branches or pull requests

2 participants