Remove custom background color support from test spacer (#2769)

Author: JakeWharton

redwood-layout-composeui/src/androidUnitTest/kotlin/app/cash/redwood/layout/composeui/ComposeUiFlexContainerTest.kt

@@ -72,9 +72,9 @@ class ComposeUiFlexContainerTest(
       applyDefaults()
     }
 
-  override fun spacer(backgroundColor: Int): Spacer<@Composable (Modifier) -> Unit> {
+  override fun spacer(): Spacer<@Composable (Modifier) -> Unit> {
     return ComposeUiSpacer().apply {
-      testOnlyModifier = Modifier.background(Color(backgroundColor))
+      testOnlyModifier = Modifier.background(Color(defaultBackgroundColor))
     }
   }
 

redwood-layout-shared-test/src/commonMain/kotlin/app/cash/redwood/layout/AbstractFlexContainerTest.kt

@@ -119,9 +119,7 @@ abstract class AbstractFlexContainerTest<T : Any> {
   /** Returns a non-lazy flex container column, even if the test is for a LazyList. */
   abstract fun column(): Column<T>
 
-  abstract fun spacer(
-    backgroundColor: Int = argb(17, 0, 0, 0),
-  ): Spacer<T>
+  abstract fun spacer(): Spacer<T>
 
   abstract fun snapshotter(widget: T): Snapshotter
 

redwood-layout-uiview/RedwoodLayoutUIViewTests/__Snapshots__/UIViewFlexContainerTestHost/testWidgetWithFlexModifierNestedInRowAndColumn.1.png

@@ -78,10 +78,10 @@ class UIViewFlexContainerTest(
     applyDefaults()
   }
 
-  override fun spacer(backgroundColor: Int): Spacer<UIView> {
+  override fun spacer(): Spacer<UIView> {
     return UIViewRedwoodLayoutWidgetFactory().Spacer()
       .apply {
-        value.backgroundColor = backgroundColor.toUIColor()
+        value.backgroundColor = defaultBackgroundColor.toUIColor()
       }
   }
 

redwood-layout-uiview/src/commonTest/kotlin/app/cash/redwood/layout/uiview/UIViewFlexContainerTest.kt

@@ -71,10 +71,10 @@ class ViewFlexContainerTest(
     applyDefaults()
   }
 
-  override fun spacer(backgroundColor: Int): Spacer<View> {
+  override fun spacer(): Spacer<View> {
     return ViewSpacer(paparazzi.context)
       .apply {
-        value.setBackgroundColor(backgroundColor)
+        value.setBackgroundColor(defaultBackgroundColor)
       }
   }
 

redwood-layout-view/src/test/kotlin/app/cash/redwood/layout/view/ViewFlexContainerTest.kt

@@ -69,11 +69,11 @@ class ComposeUiLazyListTest(
     return ComposeUiRedwoodLayoutWidgetFactory().Column()
   }
 
-  override fun spacer(backgroundColor: Int): Spacer<@Composable (Modifier) -> Unit> {
+  override fun spacer(): Spacer<@Composable (Modifier) -> Unit> {
     return ComposeUiRedwoodLayoutWidgetFactory().Spacer().apply {
       @Suppress("INVISIBLE_REFERENCE", "INVISIBLE_MEMBER")
       (this as ComposeUiSpacer).testOnlyModifier =
-        Modifier.background(Color(backgroundColor))
+        Modifier.background(Color(defaultBackgroundColor))
     }
   }
 

redwood-layout-view/src/test/snapshots/images/app.cash.redwood.layout.view_ViewFlexContainerTest_RTL_testWidgetWithFlexModifierNestedInRowAndColumn.png

@@ -51,10 +51,10 @@ class UIViewLazyListAsFlexContainerTest(
 
   override fun column() = UIViewRedwoodLayoutWidgetFactory().Column()
 
-  override fun spacer(backgroundColor: Int): Spacer<UIView> {
+  override fun spacer(): Spacer<UIView> {
     return UIViewRedwoodLayoutWidgetFactory().Spacer()
       .apply {
-        value.backgroundColor = backgroundColor.toUIColor()
+        value.backgroundColor = defaultBackgroundColor.toUIColor()
       }
   }
 

redwood-layout-view/src/test/snapshots/images/app.cash.redwood.layout.view_ViewFlexContainerTest_testWidgetWithFlexModifierNestedInRowAndColumn.png

@@ -69,10 +69,10 @@ class ViewLazyListAsFlexContainerTest(
     return ViewRedwoodLayoutWidgetFactory(paparazzi.context).Column()
   }
 
-  override fun spacer(backgroundColor: Int): Spacer<View> {
+  override fun spacer(): Spacer<View> {
     return ViewRedwoodLayoutWidgetFactory(paparazzi.context).Spacer()
       .apply {
-        value.setBackgroundColor(backgroundColor)
+        value.setBackgroundColor(defaultBackgroundColor)
       }
   }