Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude .github/ from statik's listing #77

Closed
foxyseta opened this issue Jan 6, 2025 · 1 comment · Fixed by #78
Closed

Exclude .github/ from statik's listing #77

foxyseta opened this issue Jan 6, 2025 · 1 comment · Fixed by #78
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@foxyseta
Copy link
Member

foxyseta commented Jan 6, 2025 •
edited
Loading

config/.github/workflows/statik.yaml

Line 72 in 99c979e

-e "README*"

@cartabinaria/ci-cd When invoking statik, we should probably exclude .github/, too. As this folder usually only contains .yaml files, it is usually not listed. However, cartabinaria/logica-per-informatica whitelists .yaml files:

https://github.com/cartabinaria/logica-per-informatica/blob/6ed090423462cbd4dbeb1f87003cc4c8206032a3/.github/workflows/build-and-deploy.yaml#L15

This results in .github/ appearing in the UI, even though its resources are rightfully not made available (500 internal error is issued). See https://risorse.vercel.app/logica-per-informatica?from=informatica
@foxyseta foxyseta added bug Something isn't working good first issue Good for newcomers labels Jan 6, 2025
@foxyseta foxyseta added this to Backend Jan 6, 2025
@github-project-automation github-project-automation bot moved this to New in Backend Jan 6, 2025
@samuelemusiani samuelemusiani mentioned this issue Jan 6, 2025
Merged
@samuelemusiani
Copy link
Member

samuelemusiani commented Jan 6, 2025 •
edited
Loading

I agree, #78 solves the issue. I've tested it on a clone of the logica-per-informatica repo

@foxyseta foxyseta linked a pull request Jan 6, 2025 that will close this issue
fix: exclude github from statik #78
Merged
@github-project-automation github-project-automation bot moved this from New to Done in Backend Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Backend
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclude github from statik cartabinaria/config
2 participants
@foxyseta @samuelemusiani