IE8 compatibility

[marcovtwout]

IE8 is still widely used, unfortunately your plugin is not compatible ;)

I found the following errors:

• Function does not exist https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L5
• Runtime error: https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L117 (solution: http://stackoverflow.com/questions/6631871/modifying-the-innerhtml-of-a-style-element-in-ie8)
• Function forEach does not exist https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L135

Would you care about fixing those?

[marcovtwout]

After patching these myself, I also found the "hack" where you use a checkbox to hide/show calendar items also does not work in IE8..

[mchandleraz]

Hey Marco,

Did you end up finding an alternative or solution for IE8?

[carlsednaoui]

Hi @mchandleraz, I'm actually re-writing this library from the ground up. That should hopefully help take care of that nasty bug.

Branch with work in progress: https://github.com/carlsednaoui/add-to-calendar-buttons/tree/refactor

As a side note, @marcovtwout mentioned that he ended up patching the errors himself. Perhaps he can share the end result :)

[marcovtwout]

If you are rewriting this library, my patches shouldn't be needed. :)

Just take a close look at any javascript functions you are using and if they are supported by your target browsers. I recommend following the MDN documentation, for example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach

[carlsednaoui]

@marcovtwout I know that, was just trying to save @mchandleraz some time. (Won't be a few weeks until the new version is out.)

[mchandleraz]

@marcovtwout @carlsednaoui thanks for the replies. I ended up just dropping the add to calendar feature from this project for this version because we were running out of time. I'll keep my eye on the new library though.

[ptim]

I'm looking forward to the new version, too 👍

[carlsednaoui]

Sorry for the slack on this, been busy with https://github.com/carlsednaoui/ouibounce and other projects 😢 Will definitely put some hours into the new version soon!

[marcovtwout]

As requested, here is my patched and unsupported version created one year ago: http://pastebin.com/JeC9etZc

[carlsednaoui]

@marcovtwout could you please send a PR?

[marcovtwout]

Sorry, as I said earlier, I really just patched things quickly, I don't think it is PR worthy.