Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageHeader : page actions clipping when collapsing #6857

Open
vankeisb opened this issue Feb 6, 2025 · 3 comments · May be fixed by #6858
Open

PageHeader : page actions clipping when collapsing #6857

vankeisb opened this issue Feb 6, 2025 · 3 comments · May be fixed by #6858

Comments

@vankeisb
Copy link

vankeisb commented Feb 6, 2025

When scrolling, the PageHeader collapses, with incorrect positioning. See attached .gif :

  • when collapsing, the page action button doesn't stick to the top of the header. At some point, the top of the button is clipped
  • when fully collapsed, the action buttons container clips with the content below (look to the right of "Column 3" in the red box : you can see the actions container clipping there)

Image

PS : I tried the "bug" template but I couldn't fill all the fields (code sample). Sorry about that.

@richardpilot
Copy link
Contributor

I was about to raise this myself. It can be reproduced using the storybook:
https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-page-header-pageheader--with-tabs-and-tags&args=navigation:0;tags:0&globals=viewport:basic.

This is caused by an incorrect override of min-height using the selector:
.c4p--page-header .c4p--page-header__breadcrumb-row:not(.c4p--page-header__breadcrumb-row--has-action-bar)

@vankeisb
Copy link
Author

vankeisb commented Mar 4, 2025

I submitted a PR for that :
#6858

I fixed the JS code that calculates the height. Maybe it can be done in css, idk.

@vankeisb
Copy link
Author

vankeisb commented Mar 4, 2025

Btw, as I tried to explain in the PR, the only change I made was this :
https://github.com/carbon-design-system/ibm-products/pull/6858/files#diff-18034bb44c8aed84ce71390ff8985adc8cb2993a97fe825591a0a249b806bd7aL129

The rest of the diff isn't mine. I have no idea what bot commited those and brought those conflicts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage 🧐
Development

Successfully merging a pull request may close this issue.

4 participants