Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warnings by allowing fragments to be passed in string props, etc #2719

Open
2 of 3 tasks
lily-peng opened this issue Mar 3, 2023 · 1 comment
Open
2 of 3 tasks

Comments

@lily-peng
Copy link
Contributor

lily-peng commented Mar 3, 2023

Resolve warnings by allowing fragments to be passed in string props, and more sizes for Decorators

  • Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
  • Legacy/CDAI
  • Legacy/Security

Detailed description

Hi all, we'd like some warnings handled that are being logged in the console with our IBM Products components.

In the ProductiveCard title prop, we are passing a fragment containing an icon and a string instead of just a string so we can match the design given to us.

Similarly with our OptionsTile component, in the summary prop we are passing in an HTML fragment to showcase date, time, etc but it expects a string.

Lastly, in the security Decorator component, there's a console warning when we use it with size 20, we'd like for it to accept sizes other than just 12 and 16.

Our components look and function just fine, but we just want these warnings in the console resolved. Thanks.

image
image
image
image

@lily-peng lily-peng added the type: bug 🐛 Something isn't working label Mar 3, 2023
@elycheea
Copy link
Contributor

@lily-peng Can you check that #2728 resolves the same issue you were having with the ProductiveCard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants