Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<IdeHome> background/foreground colours don't respond correctly to Carbon themes #1331

Open
2 of 3 tasks
s100 opened this issue Oct 13, 2021 · 4 comments
Open
2 of 3 tasks
Labels
package: cdai CDAI legacy package type: bug 🐛 Something isn't working

Comments

@s100
Copy link
Contributor

s100 commented Oct 13, 2021

What package(s) are you using?

@carbon/ibm-cloud-cognitive-cdai, not sure which of these applies:

  • Cloud & Cognitive
  • Legacy/CDAI
  • Legacy/Security

Detailed description

Describe in detail the issue you're having.

We import @carbon/ibm-cloud-cognitive-cdai's CSS using the following (abbreviated):

@import '~@carbon/themes/scss/themes';
$carbon--theme: $carbon--theme--g10;

@import '~carbon-components/scss/globals/scss/styles';
@import '~@carbon/ibm-cloud-cognitive-cdai/scss/index';

And we use the <IdeHome> component.

Under Carbon's "white" theme, the background of the whole UI is white. The <IdeHome> component has CSS which intentionally configures its own background colour to be a pale grey, and then the cards which sit on top of the <IdeHome> component are white again. See below:

image

(Don't worry that the <IdeHome> doesn't fill all of the vertical space, I did that to demonstrate the issue.)

However, under Carbon's "gray 10" theme, the background of the whole UI is pale grey. The <IdeHome> component has CSS which configures its own background colour to be white. But then, the cards which sit on top of the <IdeHome> component are also still white. See below:

image

Is this issue related to a specific component?

<IdeHome>

What did you expect to happen? What happened instead? What would you like to
see changed?

The cards which sit on top of <IdeHome> should always be a visibly different colour from their background, no matter what Carbon theme is in use. In this case, they should be pale grey.

What browser are you working in?

Chrome on Windows, but this is browser-independent.

What version of the @carbon/ibm-cloud-cognitive packge are you using?

@carbon/[email protected]

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

IBM App Connect Enterprise - if this could be fixed well in advance of our planned next release at the start of December 2021, that would be highly appreciated.

Steps to reproduce the issue

See above.

Please create a reduced test case in CodeSandbox

https://codesandbox.io/s/github/carbon-design-system/ibm-cloud-cognitive/tree/main/examples/cloud-cognitive/codesandbox

@s100 s100 added the type: bug 🐛 Something isn't working label Oct 13, 2021
@lee-chase lee-chase added the package: cdai CDAI legacy package label Nov 2, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: won’t fix 🔚 This will not be worked on label Apr 16, 2022
@s100
Copy link
Contributor Author

s100 commented Apr 19, 2022

@lee-chase

@stale stale bot removed the status: won’t fix 🔚 This will not be worked on label Apr 19, 2022
@stale
Copy link

stale bot commented May 27, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added status: won’t fix 🔚 This will not be worked on and removed status: won’t fix 🔚 This will not be worked on labels May 27, 2023
@s100
Copy link
Contributor Author

s100 commented May 30, 2023

Yes, still needs fixing please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: cdai CDAI legacy package type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants