Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise metrics for PageHeader to avoid anomalous situations arising even transiently #1073

Open
dcwarwick opened this issue Jul 23, 2021 · 1 comment
Labels
type: bug 🐛 Something isn't working

Comments

@dcwarwick
Copy link
Contributor

For example, the CSS variables that PageHeader sets sometimes get set to things like "undefinedpx" or "NaNpx". They immediately get set to valid values, but it would be better if this didn't happen even briefly.

Rather than initialising metrics as an empty object, then populating it on first call to the util function, and testing the fields on usage to check they've been initialised and using 0 if not, it would be better to initialise it with all the fields set to 0. Then the values can be used without checking, with confidence, and anomalous values should never arise.

@stale
Copy link

stale bot commented May 27, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: won’t fix 🔚 This will not be worked on label May 27, 2023
@github-actions github-actions bot removed the status: won’t fix 🔚 This will not be worked on label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants