Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterable Multiselect Pointer Events #1647

Open
jorgebv opened this issue Feb 1, 2023 · 0 comments · May be fixed by #1654
Open

Filterable Multiselect Pointer Events #1647

jorgebv opened this issue Feb 1, 2023 · 0 comments · May be fixed by #1654

Comments

@jorgebv
Copy link
Contributor

jorgebv commented Feb 1, 2023

As can be in the filterable multiselect example from the docs site, hovering over the expander icon retains the text input cursor instead of switching to a pointer cursor.

Viewing the comparable React component example, the React library does have a pointer cursor when hovering on the icon. This is consistent with the other visually similar components such as ComboBox.

This seems to primarily be caused by the setting of pointer-event to none on this line:

style="pointer-events: {open ? 'auto' : 'none'}"

In my local testing I see no harm from removing this style, but it seems so intentionally put there that I worry I am missing something. Do we know why pointer-events were sometimes disabled for the MultiSelect icon? Other components like the Svelte ComboBox that have similar structures and styles don't have this style. Is the line just a bug or is there something deeper lurking behind it?

I could generate a PR to remove the line and restore the pointer cursor but am hesitant since I feel like I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant