Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the attributes of the RAMCSV struct public #1

Open
ibiris opened this issue Aug 13, 2019 · 1 comment
Open

Make the attributes of the RAMCSV struct public #1

ibiris opened this issue Aug 13, 2019 · 1 comment

Comments

@ibiris
Copy link

ibiris commented Aug 13, 2019

In order to implement a series of calls to fetch a number of random lines from a CSV it would be good to know the total number of lines of the file so that the lines can be randomly chosen from the range. To do that it would help if RAMCSV exposes its attributes so that we do not need to write extra logic just to find the number of lines in the file.

Attached is a patch. I am not sure if you are actively taking PRs so please let me know if you agree and I can create a PR.
patch-randomaccesscsv.txt
@carbocation
Copy link
Owner

Sounds good to me. I'd accept and merge a PR with these changes.

carbocation added a commit that referenced this issue Sep 27, 2020
@carbocation
Add a special color (#1) that will be rendered as transparent.
6bdaf54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carbocation @ibiris