Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Firebase Performance - add support for attributes for custom traces #337

Closed
sachingarg05 opened this issue Mar 6, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists feature Feature package: performance

Comments

@sachingarg05
Copy link

Firebase supports adding attributes to traces.
https://firebase.google.com/docs/perf-mon/custom-code-traces?platform=ios#create-custom-attributes

It will be great if the start_trace API is extended to support an optional attributes parameter that is an array of attributes to attach to the trace.

Something like:
await FirebasePerformance.startTrace({ traceName: 'test_trace', attributes: ['attrib1', 'attribe2'] });

The logEvent API already supports somethings similar:

await FirebaseAnalytics.logEvent({
    name: 'sign_up',
    params: { method: 'password' },
  });
@robingenz robingenz added the duplicate This issue or pull request already exists label Dec 6, 2023
@robingenz
Copy link
Member

I close this issue as duplicate of #505

@robingenz robingenz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists feature Feature package: performance
Projects
None yet
Development

No branches or pull requests

2 participants