From b6ccc1f0976c1151d944d033c5dd8e76798da738 Mon Sep 17 00:00:00 2001 From: Ehsan Barooni <66495214+ebarooni@users.noreply.github.com> Date: Wed, 11 Dec 2024 21:09:04 +0100 Subject: [PATCH] feat(performance): add missing methods (#505) Remove record implementation from ios. --- .../ios/Plugin/FirebasePerformance.swift | 20 ---------------- .../Plugin/FirebasePerformancePlugin.swift | 23 +------------------ 2 files changed, 1 insertion(+), 42 deletions(-) diff --git a/packages/performance/ios/Plugin/FirebasePerformance.swift b/packages/performance/ios/Plugin/FirebasePerformance.swift index c5484b57..6e297289 100644 --- a/packages/performance/ios/Plugin/FirebasePerformance.swift +++ b/packages/performance/ios/Plugin/FirebasePerformance.swift @@ -67,24 +67,4 @@ import FirebasePerformance @objc public static func getMetric(_ trace: Trace, _ metricName: String) -> Int64 { return trace.valueForMetric(metricName) } - - @objc public func record(_ traceName: String, _ startTime: Double, _ duration: Double, _ attributes: [String: String], _ metrics: [String: Double]) { - let trace = getTraceByName(traceName) - let currentTime = Date().timeIntervalSince1970 * 1000 - let startDelay = max(0, (startTime - currentTime) / 1000) - - DispatchQueue.global().asyncAfter(deadline: .now() + startDelay) { - for (key, value) in attributes { - FirebasePerformance.putAttribute(trace!, key, value) - } - for (key, value) in metrics { - FirebasePerformance.putMetric(trace!, key, value) - } - self.startTrace(traceName) - - DispatchQueue.global().asyncAfter(deadline: .now() + duration / 1000) { - self.stopTrace(traceName) - } - } - } } diff --git a/packages/performance/ios/Plugin/FirebasePerformancePlugin.swift b/packages/performance/ios/Plugin/FirebasePerformancePlugin.swift index c8888dec..111a9b96 100644 --- a/packages/performance/ios/Plugin/FirebasePerformancePlugin.swift +++ b/packages/performance/ios/Plugin/FirebasePerformancePlugin.swift @@ -199,27 +199,6 @@ public class FirebasePerformancePlugin: CAPPlugin { } @objc func record(_ call: CAPPluginCall) { - guard let traceName = call.getString("traceName") else { - call.reject(errorTraceNameMissing) - return - } - guard let startTime = call.getDouble("startTime") else { - call.reject(errorStartTimeMissing) - return - } - guard let duration = call.getDouble("duration") else { - call.reject(errorDurationMissing) - return - } - let options = call.getObject("options") - let metrics = options?["metrics"] as? [String: Double] ?? [:] - let attributes = options?["attributes"] as? [String: String] ?? [:] - let trace = implementation?.getTraceByName(traceName) - guard trace != nil else { - call.reject(errorTraceNotFound) - return - } - implementation?.record(traceName, startTime, duration, attributes, metrics) - call.resolve() + call.unimplemented("Not implemented on iOS.") } }