From 610a4a16fa884ca504e5f7fc53d1f91965b798be Mon Sep 17 00:00:00 2001 From: Simon <1218015+simondaigre@users.noreply.github.com> Date: Tue, 19 Nov 2024 14:51:27 +0100 Subject: [PATCH] fix(analytics): setUserId accepts null values (#757) * fix(analytics): setUserId accepts null values * Add changeset * Update .changeset/smooth-mirrors-bow.md --------- Co-authored-by: Robin Genz --- .changeset/smooth-mirrors-bow.md | 5 +++++ packages/analytics/src/web.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/smooth-mirrors-bow.md diff --git a/.changeset/smooth-mirrors-bow.md b/.changeset/smooth-mirrors-bow.md new file mode 100644 index 00000000..504fc304 --- /dev/null +++ b/.changeset/smooth-mirrors-bow.md @@ -0,0 +1,5 @@ +--- +'@capacitor-firebase/analytics': patch +--- + +fix(web): `setUserId(...)` has set an empty string instead of `null` diff --git a/packages/analytics/src/web.ts b/packages/analytics/src/web.ts index f1a5c756..204af69f 100644 --- a/packages/analytics/src/web.ts +++ b/packages/analytics/src/web.ts @@ -60,7 +60,7 @@ export class FirebaseAnalyticsWeb public async setUserId(options: SetUserIdOptions): Promise { const analytics = getAnalytics(); - setUserId(analytics, options.userId || ''); + setUserId(analytics, options.userId); } public async setUserProperty(options: SetUserPropertyOptions): Promise {