Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search and replace URLs with old repo name #18707

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

cmur2
Copy link
Member

@cmur2 cmur2 commented May 22, 2024

Description

Find usages of the old camunda/zeebe repo name in GitHub URLs and replace with camunda/camunda.

Related issues

Related to #18206

@github-actions github-actions bot added component/zeebe Related to the Zeebe component/team component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels May 22, 2024
Copy link
Contributor

github-actions bot commented May 22, 2024

Operate Opensearch ITs Results

182 tests   182 ✅  55s ⏱️
 19 suites    0 💤
 19 files      0 ❌

Results for commit 493ebee.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 22, 2024

Operate Unit Tests Results

275 tests   274 ✅  6m 30s ⏱️
 44 suites    1 💤
 44 files      0 ❌

Results for commit 493ebee.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 22, 2024

Operate Integration Tests Results

523 tests   521 ✅  9m 59s ⏱️
 88 suites    2 💤
 88 files      0 ❌

Results for commit 493ebee.

♻️ This comment has been updated with latest results.

Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Copy link
Contributor

github-actions bot commented May 22, 2024

Tasklist Test Results

549 tests   544 ✅  1h 31m 44s ⏱️
143 suites    5 💤
143 files      0 ❌

Results for commit 493ebee.

♻️ This comment has been updated with latest results.

@Zelldon
Copy link
Member

Zelldon commented May 22, 2024

🔧 One thing @cmur2 might be worth to split the commit into smaller commits, this would allows us to easily rollback some changes. For example for go client might be worth to do, as we are not sure here about the changes :)

@cmur2 cmur2 force-pushed the 18206-monorepo-rename-url branch from 2d94725 to 34c1ec2 Compare May 22, 2024 12:07
@cmur2
Copy link
Member Author

cmur2 commented May 22, 2024

🔧 One thing @cmur2 might be worth to split the commit into smaller commits, this would allows us to easily rollback some changes. For example for go client might be worth to do, as we are not sure here about the changes :)

Good point, I split the commit into 4 different ones where 1 is for the Go client.

module github.com/camunda/zeebe/clients/go/v8
module github.com/camunda/camunda/clients/go/v8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ This is a breaking change. Are we sure we want to make this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was a conscious business decision, see project channel or this doc https://docs.google.com/document/d/1svn14wH1niB4ihr3OVhglf7qXjjcw5ZzVLzVGgQxEHE/edit?usp=drivesdk :)

@cmur2 cmur2 enabled auto-merge May 23, 2024 09:25
@cmur2 cmur2 added this pull request to the merge queue May 23, 2024
@cmur2 cmur2 removed this pull request from the merge queue due to a manual request May 23, 2024
@cmur2 cmur2 added this pull request to the merge queue May 23, 2024
@cmur2 cmur2 removed this pull request from the merge queue due to a manual request May 23, 2024
@cmur2 cmur2 force-pushed the 18206-monorepo-rename-url branch 3 times, most recently from e3f7e3c to 2c25a45 Compare May 23, 2024 10:17
@cmur2 cmur2 enabled auto-merge May 23, 2024 10:24
@cmur2 cmur2 force-pushed the 18206-monorepo-rename-url branch from 2c25a45 to 3f29464 Compare May 23, 2024 10:30
@cmur2 cmur2 added this pull request to the merge queue May 23, 2024
@cmur2 cmur2 removed this pull request from the merge queue due to a manual request May 23, 2024
@cmur2 cmur2 enabled auto-merge May 23, 2024 11:00
@cmur2 cmur2 added this pull request to the merge queue May 23, 2024
@cmur2 cmur2 removed this pull request from the merge queue due to a manual request May 23, 2024
@cmur2 cmur2 added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 06dd41e May 23, 2024
68 of 69 checks passed
@cmur2 cmur2 deleted the 18206-monorepo-rename-url branch May 23, 2024 11:25
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
…#18820)

## Description

This reverts commit 6d0887b from PR
#18707

We broke the go client usages (development environments) as we renamed
the repo AND the module names, we need to find a better way to do this.

See related incident https://app.slack.com/client/T0PM0P1SA/C074XQHKBCM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team component/zeebe Related to the Zeebe component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants