-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: search and replace URLs with old repo name #18707
Conversation
Operate Opensearch ITs Results182 tests 182 ✅ 55s ⏱️ Results for commit 493ebee. ♻️ This comment has been updated with latest results. |
Operate Unit Tests Results275 tests 274 ✅ 6m 30s ⏱️ Results for commit 493ebee. ♻️ This comment has been updated with latest results. |
Operate Integration Tests Results523 tests 521 ✅ 9m 59s ⏱️ Results for commit 493ebee. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Tasklist Test Results549 tests 544 ✅ 1h 31m 44s ⏱️ Results for commit 493ebee. ♻️ This comment has been updated with latest results. |
🔧 One thing @cmur2 might be worth to split the commit into smaller commits, this would allows us to easily rollback some changes. For example for go client might be worth to do, as we are not sure here about the changes :) |
2d94725
to
34c1ec2
Compare
Good point, I split the commit into 4 different ones where 1 is for the Go client. |
module github.com/camunda/zeebe/clients/go/v8 | ||
module github.com/camunda/camunda/clients/go/v8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ This is a breaking change. Are we sure we want to make this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this was a conscious business decision, see project channel or this doc https://docs.google.com/document/d/1svn14wH1niB4ihr3OVhglf7qXjjcw5ZzVLzVGgQxEHE/edit?usp=drivesdk :)
e3f7e3c
to
2c25a45
Compare
2c25a45
to
3f29464
Compare
…#18820) ## Description This reverts commit 6d0887b from PR #18707 We broke the go client usages (development environments) as we renamed the repo AND the module names, we need to find a better way to do this. See related incident https://app.slack.com/client/T0PM0P1SA/C074XQHKBCM
Description
Find usages of the old
camunda/zeebe
repo name in GitHub URLs and replace withcamunda/camunda
.Related issues
Related to #18206