feat: implement index dynamic schema update on opensearch #18684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component/tasklist
nathansandi
changed the base branch from
main
to
tasklist/add-unit-tests-to-schema-implementation
Tasklist Test Results40 tests - 509 40 ✅ - 504 28s ⏱️ - 1h 33m 55s Results for commit 5355976. ± Comparison against base commit c2e4ec0. This pull request removes 509 tests. |
…tasklist/add-index-dynamic-schema-update-on-opensearch
…tasklist/add-index-dynamic-schema-update-on-opensearch
… of https://github.com/camunda/zeebe into tasklist/add-index-dynamic-schema-update-on-opensearch
… into tasklist/add-integration-test-for-dynamic-schema-update
This reverts commit 46223ef.
Base automatically changed from
tasklist/add-unit-tests-to-schema-implementation
to
Implement-dynamic-schema-update-usind-index-mapping-difference
May 23, 2024 13:47
Base automatically changed from
Implement-dynamic-schema-update-usind-index-mapping-difference
to
tasklist/implement-indexdiffmappingg
May 23, 2024 13:47
…-integration-test-for-dynamic-schema-update
nathansandi
changed the title
This name is more fitting as we don't guarantee that the scheduled task is ran at the provided timestamp. The only guarantee we provide is that it is ran at some point at or after the timestamp.
This reverts commit 176af26. It's not necessary to be so explicit, as schedulers can never really achieve running at a specific timestamp.
fix: POST backups endpoint fails with 403 Closes #18588
… into tasklist/add-integration-test-for-dynamic-schema-update
…' into tasklist/update-migration-tests
tasklist/common/src/main/java/io/camunda/tasklist/property/TasklistOpenSearchProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
In this class, I don't see anything that depends on OpenSearch besides org.opensearch.client.opensearch.indices.IndexSettings
Would it be possible to have a shared component that is used by IndexSchemaValidatorOpenSearch and IndexSchemaValidatoElasticSearch to avoid duplicated code?
There was a problem hiding this comment.
I agree with this @houssain-barouni (I am already working on that in a separate branch), I will work this on a different PR once involve refactor of methods that were previous implemented as well, and in order to make the review process easier, so I will do this out of scope of this Pull Request.
This work is located on this Pull request: #18896
## Description - Create IndexSchemaValidatorUtil to store reusable methods - run lint - add zeebe client as dependency to els-schema ## Related issues closes #
nathansandi
merged commit fe133e3
into
tasklist/implement-indexdiffmappingg
10 of 15 checks passed
nathansandi
deleted the
tasklist/add-index-dynamic-schema-update-on-opensearch
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
## Description Initial PR changes: - Add the Index Schema Mapping Difference - This PR Implements the Index Difference part for Elastic search - It is a divided PR for the implementation of Elastic Search Update The second PR will make this one functional A third PR will be open for the tests Complementary pull requests merged: (Elastic Search implementation) // Already Approved 1) #18622 2) #18623 OpenSearch implementation: (To be merged/reviewed) 1) #18684 2) #18769 3) #18812 Refactor: 1) #18896 ## Related issues closes #18486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests updates:
Related issues
closes #18487