feat: support disable secret creation for apps #1091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabouzaid
added
kind/enhancement
aabouzaid
force-pushed
the
656-aa-disable-apps-auth-secrets
branch
from
a5504c1 to
a5a4726
Compare
|
Closing it because it's not possible to do it without either changing the Identity structure or making the current structure more complex. More details in #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Fixes: #656
What's in this PR?
Since all apps except Idenentiy have been moved to the main chart, and the Identity-apps secrets have been moved too, it's possible to control the creation of the secrets (in the past, the secrets would be created even if the app was disabled).
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
After opening the PR: