Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on return of dedup_citations() when manual = FALSE #49

Open
LukasWallrich opened this issue Sep 27, 2024 · 1 comment
Open

Decide on return of dedup_citations() when manual = FALSE #49

LukasWallrich opened this issue Sep 27, 2024 · 1 comment

Comments

@LukasWallrich
Copy link
Contributor

Currently, dedup_citations is documented as always returning a list, yet it returns a df when manual = FALSE. That needs to be aligned - @kaitlynhair, I think we went back and forth there - can you decide on the interface, so that we can align it?

@LukasWallrich
Copy link
Contributor Author

In the CiteSource discussion, our tendency is that it should be a list, so that changing manual = from TRUE to FALSE does not break subsequent code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant