This repository has been archived by the owner on May 2, 2023. It is now read-only.
Major refactor - strict mode and functions #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can add a I assume you've done what testing you can manually on this? |
robinbowes
force-pushed
the
use_strict_mode
branch
from
0d680b2
to
fd18101
Compare
robinbowes
force-pushed
the
use_strict_mode
branch
from
48cbc6a
to
e7dd9ec
Compare
|
This should now be good for testing. I've done some testing myself (upgraded my smartoOS node) but it probably needs more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes here:
main()entry-point.(1) means you don't need to test every command for success - the script exits if a command fails
(2) is my preferred coding style as it it makes it very clear what the script is doing
I also added a
fail()utility function.Fixes #14