Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for iframe #783

Open
petko opened this issue Oct 21, 2019 · 3 comments
Open

Fix for iframe #783

petko opened this issue Oct 21, 2019 · 3 comments

Comments

@petko
Copy link

petko commented Oct 21, 2019

I've tried to use your plugin inside TinyMCE editor. Due to the following function it does not work, but it is easy to fix by changing both occurrences of env.window.document to $obj[0].ownerDocument here:

https://github.com/iamceege/tooltipster/blob/f818f589de54165209756aa3319f49f841d708a2/src/js/tooltipster.js#L3286-L3291

TinyMCE uses iframe for the elements in the editor, so they have different document object than the main one.

@louisameline
Copy link
Collaborator

Hello, thanks for your message. So your tests show that it works with this modification?
It seems like a harmless change, this is doable.

@louisameline
Copy link
Collaborator

I wonder what the ownerDocument for detached nodes is. null maybe? If so the test needs to change slightly.

@petko
Copy link
Author

petko commented Oct 27, 2019

I can't find any information about it, but null sounds logical..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants