Skip to content

SqlServerAdapter::getColumns returns associative array #2386

@MasterOdin

Description

@MasterOdin

The SqlServerAdapter::getColumns function returns an associative array of columns, where the keys are column names. All other adapters return a numeric array which is also expressed by our AdapterInterface:

/**
* Returns table columns
*
* @param string $tableName Table name
* @return \Phinx\Db\Table\Column[]
*/
public function getColumns(string $tableName): array;

The SqlServerAdapter::getColumns method should be changed to return numeric array. As this is public facing functionality, this will require a major release.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmajorBC breaking / next major

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions