tweaks

Author: MasterOdin

src/Phinx/Db/Adapter/MysqlAdapter.php

@@ -956,10 +956,9 @@ public function getSqlType(Literal|string $type, ?int $limit = null): array
     {
         $type = (string)$type;
         switch ($type) {
-            case static::PHINX_TYPE_DECIMAL:
-                return ['name' => $type, 'precision' => 10, 'scale' => 0];
             case static::PHINX_TYPE_FLOAT:
             case static::PHINX_TYPE_DOUBLE:
+            case static::PHINX_TYPE_DECIMAL:
             case static::PHINX_TYPE_DATE:
             case static::PHINX_TYPE_ENUM:
             case static::PHINX_TYPE_SET:
@@ -1356,12 +1355,8 @@ protected function getColumnSqlDefinition(Column $column): string
             $sqlType = $this->getSqlType($column->getType(), $column->getLimit());
             $def = strtoupper($sqlType['name']);
         }
-        if ($column->getPrecision() || $column->getScale()) {
-            $def .= sprintf(
-                '(%s, %s)',
-                $column->getPrecision() ?: ($sqlType['precision'] ?? 10),
-                $column->getScale() ?: ($sqlType['scale'] ?? 0),
-            );
+        if ($column->getPrecision() && $column->getScale() !== null) {
+            $def .= '(' . $column->getPrecision() . ',' . $column->getScale() . ')';
         } elseif (isset($sqlType['limit'])) {
             $def .= '(' . $sqlType['limit'] . ')';
         }

src/Phinx/Db/Adapter/SQLiteAdapter.php

@@ -1868,7 +1868,7 @@ protected function getColumnSqlDefinition(Column $column): string
                 $def .= '(' . ($column->getLimit() ?: $sqlType['limit']) . ')';
             }
         }
-        if ($column->getPrecision() || $column->getScale()) {
+        if ($column->getPrecision() && $column->getScale() !== null) {
             $def .= sprintf(
                 '(%s, %s)',
                 $column->getPrecision() ?: 10,

tests/Phinx/Db/Adapter/SqlServerAdapterTest.php

@@ -731,15 +731,15 @@ public function testGetColumns($colName, $type, $options)
         $this->assertEquals($type, $columns[$colName]->getType());
 
         if (isset($options['limit'])) {
-            $this->assertEquals($options['limit'], $columns[1]->getLimit());
+            $this->assertEquals($options['limit'], $columns[$colName]->getLimit());
         }
 
         if (isset($options['precision'])) {
-            $this->assertEquals($options['precision'], $columns[1]->getPrecision());
+            $this->assertEquals($options['precision'], $columns[$colName]->getPrecision());
         }
 
         if (isset($options['scale'])) {
-            $this->assertEquals($options['scale'], $columns[1]->getScale());
+            $this->assertEquals($options['scale'], $columns[$colName]->getScale());
         }
     }