Bump phpstan to 1.12.x (#2363)

Author: MasterOdin

composer.json

@@ -74,7 +74,7 @@
         "cs-check": "phpcs",
         "cs-fix": "phpcbf",
         "stan": "phpstan analyse",
-        "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:~1.9.0 && mv composer.backup composer.json",
+        "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:~1.12.0 && mv composer.backup composer.json",
         "lowest": "validate-prefer-lowest",
         "lowest-setup": "composer update --prefer-lowest --prefer-stable --prefer-dist --no-interaction && cp composer.json composer.backup && composer require --dev dereuromark/composer-prefer-lowest && mv composer.backup composer.json",
         "test": "phpunit --colors=always"

phpstan-baseline.neon

@@ -1,10 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: "#^Variable \\$tval on left side of \\?\\? always exists and is not nullable\\.$#"
-			count: 1
-			path: src/Phinx/Config/Config.php
-
 		-
 			message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
 			count: 1

src/Phinx/Db/Adapter/SQLiteAdapter.php

@@ -1168,8 +1168,8 @@ protected function calculateNewTableColumns(string $tableName, string|false $col
             $writeColumns[] = $writeName;
         }
 
-        $selectColumns = array_filter($selectColumns, 'strlen');
-        $writeColumns = array_filter($writeColumns, 'strlen');
+        $selectColumns = array_filter($selectColumns, fn($v) => $v && strlen($v) > 0);
+        $writeColumns = array_filter($writeColumns, fn($v) => $v && strlen($v) > 0);
         $selectColumns = array_map([$this, 'quoteColumnName'], $selectColumns);
         $writeColumns = array_map([$this, 'quoteColumnName'], $writeColumns);