Update Cake.Buns.ReportPortal.yml #1924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalberger
requested changes
Apr 10, 2021
| @@ -3,8 +3,8 @@ Name: Cake.Buns.ReportPortal | |||
| NuGet: Cake.Buns.ReportPortal | |||
| Assemblies: | |||
| - /**/Cake.Buns.ReportPortal.dll | |||
| Repository: https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal.git | |||
| ProjectUrl: https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal/ | |||
| Repository: https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal/ | |||
There was a problem hiding this comment.
Repository / GitHub user seems to be removed.
@Jericho Isn't there a check in addin discoverer to avoid adding links leading to a 404 (or was the user removed just after addin discoverer was run)?
There was a problem hiding this comment.
We do validate the ProjectUrl and replace it with a link to the nuget package when we detect HTTP 404. That's why the ProjectUrl in this YAML was changed:
- from
https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal/ - to
https://www.nuget.org/packages/Cake.Buns.ReportPortal/.
However, the same logic is not applied to the repository URL. That's why the AddinDiscoverer did not update the RepositoryUrl (other than .git which the author seems to have removed in their nuspec).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created by a tool: Cake.AddinDiscoverer version 3.74.0
Resolves #1923