Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set multiple of the same attribute CustomAttributes in AssemblyInfo creator #4071

Open
2 tasks done
squid-box opened this issue Nov 15, 2022 · 1 comment
Open
2 tasks done

Comments

@squid-box
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

Cake runner

Cake .NET Tool

Cake version

3.0.0

Operating system

Windows

Operating system architecture

64-Bit

CI Server

No response

What are you seeing?

I'm trying to set two attributes for SupportedOSPlatform (with different values) in my AssemblyInfo generated through Cake, by adding them as CustomAttributes.

It seems only the last value added to this list is actually added to the assembly info, and from a brief look at this class I guess it comes from the custom attributes being stored in a Dictionary?

What is expected?

I expect to have all the custom attributes I specify added to my AssemblyInfo file, even if they have multiple instances of the same attribute.

Steps to Reproduce

Trivial example:

CreateAssemblyInfo(File("SomeDir/My_AssemblyInfo.cs"), new AssemblyInfoSettings
{
    Version = "1.2.3.4",
    Company = "MyCompany",
    CustomAttributes = new List<AssemblyInfoCustomAttribute>
    {
        new AssemblyInfoCustomAttribute
        {
            Name = "SupportedOSPlatform",
            NameSpace = "System.Runtime.Versioning",
            UseRawValue = false,
            Value = "windows"
        },
        new AssemblyInfoCustomAttribute
        {
            Name = "SupportedOSPlatform",
            NameSpace = "System.Runtime.Versioning",
            UseRawValue = false,
            Value = "linux"
        },
    }
});

Output log

No response

@squid-box squid-box changed the title Unable to set multiple CustomAttributes in AssemblyInfo creator Unable to set multiple of the same attribute CustomAttributes in AssemblyInfo creator Nov 15, 2022
@squid-box
Copy link
Author

I'm not sure if the correct approach here is to make it possible to have several instances of the same attribute in CustomAttributes, or introduce a new (collection) property specifically for the SupportedOSPlatform attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant