Skip to content

Commit 57ad14a

Browse files
committed
Improve naming in Test project.
1 parent 040390b commit 57ad14a

5 files changed

+48
-48
lines changed

SqlAppLockHelper.Tests/MicrosoftDataConnectionAppLockTests.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class TestMicrosoftDataAppLock
1212
[TestMethod]
1313
public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
1414
{
15-
await using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
15+
await using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
1616
await sqlConn.OpenAsync();
1717

1818
//Acquire the Lock & Validate
@@ -27,7 +27,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
2727
Assert.IsFalse(string.IsNullOrWhiteSpace(appLock.LockName));
2828

2929
////Attempt Acquisition from SECOND Connection Once Locked & Validate...
30-
await using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
30+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
3131
await sqlConnWhileLocked.OpenAsync();
3232

3333
await using var appLockFailWhileLocked = await sqlConnWhileLocked.AcquireAppLockAsync(
@@ -49,7 +49,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
4949

5050
//Attempt Reacquisition of the Lock Once Released!
5151
//Get a new Transaction to test re-acquisition!
52-
await using var sqlConnAfterRelease = TestHelper.CreateMicrosoftDataSqlConnection();
52+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
5353
await sqlConnAfterRelease.OpenAsync();
5454

5555
await using var appLockAfterRelease = await sqlConnAfterRelease.AcquireAppLockAsync(
@@ -66,7 +66,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
6666
[TestMethod]
6767
public async Task TestAsyncConnectionAppLockAcquisitionWithExceptions()
6868
{
69-
await using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
69+
await using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
7070
await sqlConn.OpenAsync();
7171

7272
//Acquire the Lock & Validate
@@ -79,7 +79,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionWithExceptions()
7979
//Attempt Acquisition from SECOND Connection Once Locked & Validate...
8080
try
8181
{
82-
await using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
82+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
8383
await sqlConnWhileLocked.OpenAsync();
8484

8585
await using var appLockFailWhileLocked = await sqlConnWhileLocked.AcquireAppLockAsync(
@@ -100,7 +100,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionWithExceptions()
100100
[TestMethod]
101101
public async Task TestAsyncConnectionAppLockExplicitRelease()
102102
{
103-
await using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
103+
await using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
104104
await sqlConn.OpenAsync();
105105

106106
//Acquire the Lock & Validate
@@ -119,7 +119,7 @@ public async Task TestAsyncConnectionAppLockExplicitRelease()
119119
[TestMethod]
120120
public async Task TestAsyncConnectionAppLockExplicitReleaseAsync()
121121
{
122-
await using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
122+
await using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
123123
await sqlConn.OpenAsync();
124124

125125
//Acquire the Lock & Validate
@@ -132,7 +132,7 @@ public async Task TestAsyncConnectionAppLockExplicitReleaseAsync()
132132
//Explicitly Release the AppLock & Validate
133133
await appLock.ReleaseAsync();
134134

135-
await using var sqlConnAfterRelease = TestHelper.CreateMicrosoftDataSqlConnection();
135+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
136136
await sqlConnAfterRelease.OpenAsync();
137137

138138
//Acquire the Lock & Validate
@@ -146,7 +146,7 @@ public async Task TestAsyncConnectionAppLockExplicitReleaseAsync()
146146
[TestMethod]
147147
public void TestAsyncConnectionAppLockExplicitReleaseSync()
148148
{
149-
using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
149+
using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
150150
sqlConn.Open();
151151

152152
//Acquire the Lock & Validate
@@ -159,7 +159,7 @@ public void TestAsyncConnectionAppLockExplicitReleaseSync()
159159
//Explicitly Release the AppLock & Validate
160160
appLock.Release();
161161

162-
using var sqlConnAfterRelease = TestHelper.CreateMicrosoftDataSqlConnection();
162+
using var sqlConnAfterRelease = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
163163
sqlConnAfterRelease.Open();
164164

165165
//Acquire the Lock & Validate
@@ -173,7 +173,7 @@ public void TestAsyncConnectionAppLockExplicitReleaseSync()
173173
[TestMethod]
174174
public async Task TestAsyncConnectionAppLockReleaseWithConnectionDisposalWithUsing()
175175
{
176-
await using (var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection())
176+
await using (var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection())
177177
{
178178
await sqlConn.OpenAsync();
179179

@@ -190,7 +190,7 @@ public async Task TestAsyncConnectionAppLockReleaseWithConnectionDisposalWithUsi
190190
Assert.IsFalse(string.IsNullOrWhiteSpace(appLock.LockName));
191191

192192
////Attempt Acquisition from SECOND Connection Once Locked & Validate...
193-
await using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
193+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
194194
await sqlConnWhileLocked.OpenAsync();
195195

196196
await using var appLockFailWhileLocked = await sqlConnWhileLocked.AcquireAppLockAsync(
@@ -207,7 +207,7 @@ public async Task TestAsyncConnectionAppLockReleaseWithConnectionDisposalWithUsi
207207

208208
//Attempt Reacquisition of the Lock Once Released via Sql Connection Disposal (from using{} scope) above!
209209
//Get a new Transaction to test re-acquisition!
210-
await using var sqlConnAfterRelease = TestHelper.CreateMicrosoftDataSqlConnection();
210+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
211211
await sqlConnAfterRelease.OpenAsync();
212212

213213
await using var appLockAfterRelease = await sqlConnAfterRelease.AcquireAppLockAsync(

SqlAppLockHelper.Tests/MicrosoftDataTransactionAppLockTests.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class TestMicrosoftDataTransactionAppLock
1212
[TestMethod]
1313
public async Task TestAsyncTransactionAppLockAcquisitionExceptionsDisabled()
1414
{
15-
await using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
15+
await using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
1616
await sqlConn.OpenAsync();
1717

1818
await using var sqlTrans = (SqlTransaction)await sqlConn.BeginTransactionAsync();
@@ -30,7 +30,7 @@ public async Task TestAsyncTransactionAppLockAcquisitionExceptionsDisabled()
3030
Assert.IsFalse(string.IsNullOrWhiteSpace(appLock.LockName));
3131

3232
//Attempt Acquisition from SECOND Connection Once Locked & Validate...
33-
await using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
33+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
3434
await sqlConnWhileLocked.OpenAsync();
3535

3636
await using var sqlTransWhileLocked = (SqlTransaction)await sqlConnWhileLocked.BeginTransactionAsync();
@@ -49,7 +49,7 @@ public async Task TestAsyncTransactionAppLockAcquisitionExceptionsDisabled()
4949

5050
//Attempt Reacquisition of the Lock Once Released!
5151
//Get a new Transaction to test re-acquisition!
52-
await using var sqlConnAfterRelease = TestHelper.CreateMicrosoftDataSqlConnection();
52+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
5353
await sqlConnAfterRelease.OpenAsync();
5454

5555
var sqlTransAfterRelease = (SqlTransaction)await sqlConnAfterRelease.BeginTransactionAsync();
@@ -67,7 +67,7 @@ public async Task TestAsyncTransactionAppLockAcquisitionExceptionsDisabled()
6767
[TestMethod]
6868
public async Task TestAsyncTransactionAppLockAcquisitionWithExceptions()
6969
{
70-
await using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
70+
await using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
7171
await sqlConn.OpenAsync();
7272

7373
await using var sqlTrans = (SqlTransaction)await sqlConn.BeginTransactionAsync();
@@ -82,7 +82,7 @@ public async Task TestAsyncTransactionAppLockAcquisitionWithExceptions()
8282
//Attempt Acquisition from SECOND Connection Once Locked & Validate...
8383
try
8484
{
85-
await using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
85+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
8686
await sqlConnWhileLocked.OpenAsync();
8787

8888
await using var sqlTransWhileLocked = (SqlTransaction)await sqlConnWhileLocked.BeginTransactionAsync();
@@ -104,7 +104,7 @@ public async Task TestAsyncTransactionAppLockAcquisitionWithExceptions()
104104
[TestMethod]
105105
public void TestSyncTransactionAppLockAcquisitionExceptionsDisabled()
106106
{
107-
using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
107+
using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
108108
sqlConn.Open();
109109

110110
using var sqlTrans = (SqlTransaction)sqlConn.BeginTransaction();
@@ -117,7 +117,7 @@ public void TestSyncTransactionAppLockAcquisitionExceptionsDisabled()
117117
Assert.IsFalse(string.IsNullOrWhiteSpace(appLock.LockName));
118118

119119
//Attempt Acquisition from SECOND Connection Once Locked & Validate...
120-
using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
120+
using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
121121
sqlConnWhileLocked.Open();
122122

123123
using var sqlTransWhileLocked = (SqlTransaction)sqlConnWhileLocked.BeginTransaction();
@@ -135,7 +135,7 @@ public void TestSyncTransactionAppLockAcquisitionExceptionsDisabled()
135135

136136
//Attempt Reacquisition of the Lock Once Released!
137137
//Get a new Transaction to test re-acquisition!
138-
using var sqlConnAfterRelease = TestHelper.CreateMicrosoftDataSqlConnection();
138+
using var sqlConnAfterRelease = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
139139
sqlConnAfterRelease.Open();
140140

141141
var sqlTransAfterRelease = (SqlTransaction)sqlConnAfterRelease.BeginTransaction();
@@ -153,7 +153,7 @@ public void TestSyncTransactionAppLockAcquisitionExceptionsDisabled()
153153
[TestMethod]
154154
public void TestSyncTransactionAppLockAcquisitionWithExceptions()
155155
{
156-
using var sqlConn = TestHelper.CreateMicrosoftDataSqlConnection();
156+
using var sqlConn = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
157157
sqlConn.Open();
158158

159159
using var sqlTrans = (SqlTransaction)sqlConn.BeginTransaction();
@@ -168,7 +168,7 @@ public void TestSyncTransactionAppLockAcquisitionWithExceptions()
168168
//Attempt Acquisition from SECOND Connection Once Locked & Validate...
169169
try
170170
{
171-
using var sqlConnWhileLocked = TestHelper.CreateMicrosoftDataSqlConnection();
171+
using var sqlConnWhileLocked = SqlConnectionHelper.CreateMicrosoftDataSqlConnection();
172172
sqlConnWhileLocked.Open();
173173

174174
using var sqlTransWhileLocked = (SqlTransaction)sqlConnWhileLocked.BeginTransaction();

SqlAppLockHelper.Tests/TestHelper.cs renamed to SqlAppLockHelper.Tests/SqlConnectionHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace SqlAppLockHelper.Tests
88
{
9-
public class TestHelper
9+
public class SqlConnectionHelper
1010
{
1111
public static SystemData.SqlConnection CreateSystemDataSqlConnection()
1212
{

SqlAppLockHelper.Tests/SystemDataConnectionAppLockTests.cs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class TestSystemDataAppLock
1212
[TestMethod]
1313
public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
1414
{
15-
await using var sqlConn = TestHelper.CreateSystemDataSqlConnection();
15+
await using var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection();
1616
await sqlConn.OpenAsync();
1717

1818
//Acquire the Lock & Validate
@@ -27,7 +27,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
2727
Assert.IsFalse(string.IsNullOrWhiteSpace(appLock.LockName));
2828

2929
////Attempt Acquisition from SECOND Connection Once Locked & Validate...
30-
await using var sqlConnWhileLocked = TestHelper.CreateSystemDataSqlConnection();
30+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateSystemDataSqlConnection();
3131
await sqlConnWhileLocked.OpenAsync();
3232

3333
await using var appLockFailWhileLocked = await sqlConnWhileLocked.AcquireAppLockAsync(
@@ -49,7 +49,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
4949

5050
//Attempt Reacquisition of the Lock Once Released!
5151
//Get a new Transaction to test re-acquisition!
52-
await using var sqlConnAfterRelease = TestHelper.CreateSystemDataSqlConnection();
52+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateSystemDataSqlConnection();
5353
await sqlConnAfterRelease.OpenAsync();
5454

5555
await using var appLockAfterRelease = await sqlConnAfterRelease.AcquireAppLockAsync(
@@ -66,7 +66,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
6666
[TestMethod]
6767
public async Task TestAsyncConnectionAppLockAcquisitionWithExceptions()
6868
{
69-
await using var sqlConn = TestHelper.CreateSystemDataSqlConnection();
69+
await using var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection();
7070
await sqlConn.OpenAsync();
7171

7272
//Acquire the Lock & Validate
@@ -79,7 +79,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionWithExceptions()
7979
//Attempt Acquisition from SECOND Connection Once Locked & Validate...
8080
try
8181
{
82-
await using var sqlConnWhileLocked = TestHelper.CreateSystemDataSqlConnection();
82+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateSystemDataSqlConnection();
8383
await sqlConnWhileLocked.OpenAsync();
8484

8585
await using var appLockFailWhileLocked = await sqlConnWhileLocked.AcquireAppLockAsync(
@@ -100,7 +100,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionWithExceptions()
100100
[TestMethod]
101101
public async Task TestAsyncConnectionAppLockExplicitDisposalAsync()
102102
{
103-
await using var sqlConn = TestHelper.CreateSystemDataSqlConnection();
103+
await using var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection();
104104
await sqlConn.OpenAsync();
105105

106106
//Acquire the Lock & Validate
@@ -119,7 +119,7 @@ public async Task TestAsyncConnectionAppLockExplicitDisposalAsync()
119119
[TestMethod]
120120
public void TestAsyncConnectionAppLockExplicitDisposalSync()
121121
{
122-
using var sqlConn = TestHelper.CreateSystemDataSqlConnection();
122+
using var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection();
123123
sqlConn.Open();
124124

125125
//Acquire the Lock & Validate
@@ -138,7 +138,7 @@ public void TestAsyncConnectionAppLockExplicitDisposalSync()
138138
[TestMethod]
139139
public async Task TestAsyncConnectionAppLockExplicitReleaseAsync()
140140
{
141-
await using var sqlConn = TestHelper.CreateSystemDataSqlConnection();
141+
await using var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection();
142142
await sqlConn.OpenAsync();
143143

144144
//Acquire the Lock & Validate
@@ -151,7 +151,7 @@ public async Task TestAsyncConnectionAppLockExplicitReleaseAsync()
151151
//Explicitly Release the AppLock & Validate
152152
await appLock.ReleaseAsync();
153153

154-
await using var sqlConnAfterRelease = TestHelper.CreateSystemDataSqlConnection();
154+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateSystemDataSqlConnection();
155155
await sqlConnAfterRelease.OpenAsync();
156156

157157
//Acquire the Lock & Validate
@@ -165,7 +165,7 @@ public async Task TestAsyncConnectionAppLockExplicitReleaseAsync()
165165
[TestMethod]
166166
public void TestAsyncConnectionAppLockExplicitReleaseSync()
167167
{
168-
using var sqlConn = TestHelper.CreateSystemDataSqlConnection();
168+
using var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection();
169169
sqlConn.Open();
170170

171171
//Acquire the Lock & Validate
@@ -178,7 +178,7 @@ public void TestAsyncConnectionAppLockExplicitReleaseSync()
178178
//Explicitly Release the AppLock & Validate
179179
appLock.Release();
180180

181-
using var sqlConnAfterRelease = TestHelper.CreateSystemDataSqlConnection();
181+
using var sqlConnAfterRelease = SqlConnectionHelper.CreateSystemDataSqlConnection();
182182
sqlConnAfterRelease.Open();
183183

184184
//Acquire the Lock & Validate
@@ -192,7 +192,7 @@ public void TestAsyncConnectionAppLockExplicitReleaseSync()
192192
[TestMethod]
193193
public async Task TestAsyncConnectionAppLockReleaseWithConnectionDisposalWithUsing()
194194
{
195-
await using (var sqlConn = TestHelper.CreateSystemDataSqlConnection())
195+
await using (var sqlConn = SqlConnectionHelper.CreateSystemDataSqlConnection())
196196
{
197197
await sqlConn.OpenAsync();
198198

@@ -209,7 +209,7 @@ public async Task TestAsyncConnectionAppLockReleaseWithConnectionDisposalWithUsi
209209
Assert.IsFalse(string.IsNullOrWhiteSpace(appLock.LockName));
210210

211211
////Attempt Acquisition from SECOND Connection Once Locked & Validate...
212-
await using var sqlConnWhileLocked = TestHelper.CreateSystemDataSqlConnection();
212+
await using var sqlConnWhileLocked = SqlConnectionHelper.CreateSystemDataSqlConnection();
213213
await sqlConnWhileLocked.OpenAsync();
214214

215215
await using var appLockFailWhileLocked = await sqlConnWhileLocked.AcquireAppLockAsync(
@@ -226,7 +226,7 @@ public async Task TestAsyncConnectionAppLockReleaseWithConnectionDisposalWithUsi
226226

227227
//Attempt Reacquisition of the Lock Once Released via Sql Connection Disposal (from using{} scope) above!
228228
//Get a new Transaction to test re-acquisition!
229-
await using var sqlConnAfterRelease = TestHelper.CreateSystemDataSqlConnection();
229+
await using var sqlConnAfterRelease = SqlConnectionHelper.CreateSystemDataSqlConnection();
230230
await sqlConnAfterRelease.OpenAsync();
231231

232232
await using var appLockAfterRelease = await sqlConnAfterRelease.AcquireAppLockAsync(

0 commit comments

Comments
 (0)