-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] return search attributes that can be used advanced visibility #4139
Comments
Can I take this issue? |
Absolutely. Actually it’s better to add this to the existing API “describeCluster” you can follow these two PRs: |
I guess the PR solving this issue has already been merged right? |
Which PR? No, I thought you will open new PR to solve it |
Okay, I actually thought that we have to make an api which returned the attributes which would then later on used by the search feature and I thought it was completed by PR#4136 |
Yup, that was the plan :) |
No, that PR only return persistence info. We want the ES valid fields info here. So you will open a new PR to return it like that PR I link to that PR just for you to follow |
Thanks 😃lmk if you still have questions |
Okay, I guess I have concrete view of the problem now. |
@neel229 If you are still interested in contributing, would you mind moving to this one? #3962 |
Is your feature request related to a problem? Please describe.
It will make cadence-workflow/cadence-web#281 possible
Proposed Solution
Return the data from this value: https://github.com/uber/cadence/blob/d0a8f7e6a9297bd898ea5b10ded20f0277a8980f/service/frontend/adminHandler.go#L190
add this to the existing API “describeCluster”
follow these two PRs:
cadence-workflow/cadence-idl#62
#4136
To add the information
Additional context
N/A
The text was updated successfully, but these errors were encountered: