Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] return search attributes that can be used advanced visibility #4139

Closed
longquanzheng opened this issue Apr 16, 2021 · 10 comments
Labels
good first issue Up for grab as first issue to contribute to Cadence project up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Apr 16, 2021

Is your feature request related to a problem? Please describe.
It will make cadence-workflow/cadence-web#281 possible

Proposed Solution
Return the data from this value: https://github.com/uber/cadence/blob/d0a8f7e6a9297bd898ea5b10ded20f0277a8980f/service/frontend/adminHandler.go#L190

add this to the existing API “describeCluster”

follow these two PRs:
cadence-workflow/cadence-idl#62
#4136

To add the information
Additional context
N/A

@longquanzheng longquanzheng added up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute good first issue Up for grab as first issue to contribute to Cadence project labels Apr 16, 2021
@stuckinforloop
Copy link

Can I take this issue?

@longquanzheng
Copy link
Contributor Author

Can I take this issue?

Absolutely. Actually it’s better to add this to the existing API “describeCluster”

you can follow these two PRs:
cadence-workflow/cadence-idl#62
#4136

@longquanzheng longquanzheng changed the title [Feature Request] new API to return search attributes that can be used advanced visibility [Feature Request] return search attributes that can be used advanced visibility Apr 17, 2021
@stuckinforloop
Copy link

stuckinforloop commented Apr 21, 2021

I guess the PR solving this issue has already been merged right?

@longquanzheng
Copy link
Contributor Author

I guess the PR solving this issue has already been merged right?

Which PR? No, I thought you will open new PR to solve it

@stuckinforloop
Copy link

Okay, I actually thought that we have to make an api which returned the attributes which would then later on used by the search feature and I thought it was completed by PR#4136

@stuckinforloop
Copy link

I guess the PR solving this issue has already been merged right?

Which PR? No, I thought you will open new PR to solve it

Yup, that was the plan :)

@longquanzheng
Copy link
Contributor Author

Okay, I actually thought that we have to make an api which returned the attributes which would then later on used by the search feature and I thought it was completed by PR#4136

No, that PR only return persistence info. We want the ES valid fields info here. So you will open a new PR to return it like that PR

I link to that PR just for you to follow

@longquanzheng
Copy link
Contributor Author

I guess the PR solving this issue has already been merged right?

Which PR? No, I thought you will open new PR to solve it

Yup, that was the plan :)

Thanks 😃lmk if you still have questions

@stuckinforloop
Copy link

Okay, I actually thought that we have to make an api which returned the attributes which would then later on used by the search feature and I thought it was completed by PR#4136

No, that PR only return persistence info. We want the ES valid fields info here. So you will open a new PR to return it like that PR

I link to that PR just for you to follow

Okay, I guess I have concrete view of the problem now.

@longquanzheng
Copy link
Contributor Author

@neel229
I am so sorry, just realized that the API actually already exists: https://github.com/uber/cadence/blob/30702c2e0620d7176da5847221029a9dfb3013fa/service/frontend/workflowHandler.go#L3057

If you are still interested in contributing, would you mind moving to this one? #3962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grab as first issue to contribute to Cadence project up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Development

No branches or pull requests

2 participants