Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabot includes an option for SSL, but requirement missing from cabot-alert-email #8

Open
dbuxton opened this issue Nov 6, 2017 · 1 comment

Comments

@dbuxton
Copy link
Contributor

dbuxton commented Nov 6, 2017

See conversation at the end of arachnys/cabot#4

Basically our default settings are for SES which requires (as I recall, maybe it's changed) SSL (and thus https://github.com/bancek/django-smtp-ssl) for SMTP.

However our default Cabot requirements.txt doesn't include this package and neither does this repo.

Solution: add dependency for django-smtp-ssl to setup.py of this plugin.

(This problem also exists with e.g. https://github.com/cabotapp/cabot-alert-twilio/blob/master/setup.py although in that case we include in the cabot requirements: https://github.com/arachnys/cabot/blob/af66cc806d516239281e35226f43a2dc4dbef18c/requirements.txt#L43)

@dbuxton dbuxton changed the title Cabot includes an option for Cabot includes an option for SSL, but requirement missing from cabot-alert-email Nov 6, 2017
@frankh
Copy link
Contributor

frankh commented Nov 7, 2017

Django now supports SSL in django.core.mail.backends.smtp.EmailBackend, and django-smtp-ssl hasn't been updated in years, so I don't think switching back to that is the solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants