Skip to content

Commit 049924f

Browse files
committed
Remove beta field
1 parent 781e423 commit 049924f

File tree

3 files changed

+8
-18
lines changed

3 files changed

+8
-18
lines changed

Version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.6.2
1+
1.6.3

internal/services/tokenissuer.go

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ type TokenIssuer struct {
2626
Tenant string
2727
}
2828

29-
func (issuer *TokenIssuer) GenerateUserToken(groups []string, username string, email string, hasAdminAccess bool, hasApplicationAccess bool, hasOpsAccess bool, beta bool) (*string, error) {
29+
func (issuer *TokenIssuer) GenerateUserToken(groups []string, username string, email string, hasAdminAccess bool, hasApplicationAccess bool, hasOpsAccess bool) (*string, error) {
3030

3131
var auths = GetUserNamespaces(groups)
3232

3333
duration, err := time.ParseDuration(issuer.TokenDuration)
3434
current := time.Now().Add(duration)
3535
url, _ := url.Parse(issuer.PublicApiServerURL)
3636

37-
if beta && (hasAdminAccess || hasApplicationAccess || hasOpsAccess) {
37+
if hasAdminAccess || hasApplicationAccess || hasOpsAccess {
3838
utils.Log.Info().Msgf("The user %s will have transversal access ( admin: %v, application: %v, ops: %v )", username, hasAdminAccess, hasApplicationAccess, hasOpsAccess)
3939
auths = []*types.Project{}
4040
}
@@ -65,7 +65,7 @@ func (issuer *TokenIssuer) GenerateUserToken(groups []string, username string, e
6565
return &signedToken, err
6666
}
6767

68-
func (issuer *TokenIssuer) baseGenerateToken(auth types.Auth, beta bool) (*string, error) {
68+
func (issuer *TokenIssuer) baseGenerateToken(auth types.Auth) (*string, error) {
6969

7070
userDN, mail, err := ldap.AuthenticateUser(auth.Username, auth.Password)
7171
if err != nil {
@@ -77,7 +77,7 @@ func (issuer *TokenIssuer) baseGenerateToken(auth types.Auth, beta bool) (*strin
7777
utils.TokenCounter.WithLabelValues("token_error").Inc()
7878
return nil, err
7979
}
80-
token, err := issuer.GenerateUserToken(groups, auth.Username, *mail, ldap.HasAdminAccess(*userDN), ldap.HasApplicationAccess(*userDN), ldap.HasOpsAccess(*userDN), beta)
80+
token, err := issuer.GenerateUserToken(groups, auth.Username, *mail, ldap.HasAdminAccess(*userDN), ldap.HasApplicationAccess(*userDN), ldap.HasOpsAccess(*userDN))
8181

8282
if err != nil {
8383
utils.TokenCounter.WithLabelValues("token_error").Inc()
@@ -95,12 +95,7 @@ func (issuer *TokenIssuer) GenerateJWT(w http.ResponseWriter, r *http.Request) {
9595
io.WriteString(w, "Basic Auth: Invalid credentials")
9696
}
9797

98-
betaMode := false
99-
if r.Header.Get("X-API-MODE") == "beta" {
100-
betaMode = true
101-
}
102-
103-
token, err := issuer.baseGenerateToken(*auth, betaMode)
98+
token, err := issuer.baseGenerateToken(*auth)
10499
if err == nil {
105100
utils.Log.Info().Msgf("Granting token for user %v", auth.Username)
106101
w.WriteHeader(http.StatusCreated)
@@ -117,11 +112,6 @@ func (issuer *TokenIssuer) GenerateJWT(w http.ResponseWriter, r *http.Request) {
117112
func (issuer *TokenIssuer) GenerateConfig(w http.ResponseWriter, r *http.Request) {
118113
err, auth := issuer.basicAuth(r)
119114

120-
betaMode := false
121-
if r.Header.Get("X-API-MODE") == "beta" {
122-
betaMode = true
123-
}
124-
125115
if err != nil {
126116
utils.Log.Info().Err(err)
127117
utils.Log.Info().Msg(err.Error())
@@ -130,7 +120,7 @@ func (issuer *TokenIssuer) GenerateConfig(w http.ResponseWriter, r *http.Request
130120

131121
}
132122

133-
token, err := issuer.baseGenerateToken(*auth, betaMode)
123+
token, err := issuer.baseGenerateToken(*auth)
134124
if err == nil {
135125
utils.Log.Info().Msgf("Granting token for user %v", auth.Username)
136126
} else {

internal/services/tokenissuer_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestECDSA(t *testing.T) {
3838

3939
t.Run("Generate a valid User token", func(t *testing.T) {
4040

41-
token, err := issuer.GenerateUserToken([]string{"DL_ns-development_admin", "DL_ns-devops-automation-integration_admin"}, "unit", "[email protected]", true, true, false, false)
41+
token, err := issuer.GenerateUserToken([]string{"DL_ns-development_admin", "DL_ns-devops-automation-integration_admin"}, "unit", "[email protected]", true, true, false)
4242
assert.Nil(t, err)
4343
assert.NotNil(t, token)
4444
utils.Log.Info().Msgf("The token is %s", *token)

0 commit comments

Comments
 (0)