Skip to content

Commit e40fb26

Browse files
committed
Improve time complexity from N^2 to N
1 parent 0e6ce2e commit e40fb26

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/java/org/mskcc/cbio/portal/scripts/GeneticAlterationIncrementalImporter.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import java.util.HashSet;
1313
import java.util.List;
1414
import java.util.Map;
15+
import java.util.Set;
1516

1617
public class GeneticAlterationIncrementalImporter extends GeneticAlterationImporter {
1718

@@ -57,7 +58,8 @@ public void initialise() {
5758
});
5859
// add all new sample ids at the end
5960
this.orderedSampleList = new ArrayList<>(savedOrderedSampleList);
60-
List<Integer> newSampleIds = this.fileOrderedSampleList.stream().filter(sampleId -> !savedOrderedSampleList.contains(sampleId)).toList();
61+
Set<Integer> savedSampleSet = new HashSet<>(savedOrderedSampleList);
62+
List<Integer> newSampleIds = this.fileOrderedSampleList.stream().filter(sampleId -> !savedSampleSet.contains(sampleId)).toList();
6163
this.orderedSampleList.addAll(newSampleIds);
6264
DaoGeneticProfileSamples.deleteAllSamplesInGeneticProfile(this.geneticProfileId);
6365
daoGeneticAlteration.deleteAllRecordsInGeneticProfile(this.geneticProfileId);

0 commit comments

Comments
 (0)